From 8b523ca12541ba003966a6f3e24a0edca1886c89 Mon Sep 17 00:00:00 2001 From: Niklas Liechti <2284764+nliechti@users.noreply.github.com> Date: Tue, 23 Sep 2025 10:00:48 +0200 Subject: [PATCH] Improve devcontainer behaviour on ARM Macs (#1707) * Remove hardcoded amd64 images. This slows down development on ARM Macs significantly. * Do not use prebuilt bench image as it may be outdated or not available as an ARM build. The source image is in this repo anyway. * Use the prebuilt image by default. --- devcontainer-example/docker-compose.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/devcontainer-example/docker-compose.yml b/devcontainer-example/docker-compose.yml index 39f509d5..0a614cbf 100644 --- a/devcontainer-example/docker-compose.yml +++ b/devcontainer-example/docker-compose.yml @@ -2,7 +2,6 @@ version: "3.7" services: mariadb: image: docker.io/mariadb:10.6 - platform: linux/amd64 command: - --character-set-server=utf8mb4 - --collation-server=utf8mb4_unicode_ci @@ -38,15 +37,14 @@ services: redis-cache: image: docker.io/redis:alpine - platform: linux/amd64 redis-queue: image: docker.io/redis:alpine - platform: linux/amd64 frappe: image: docker.io/frappe/bench:latest - platform: linux/amd64 + # If you want to build the current bench image the Containerfile is in this Repo. + # build: ../images/bench command: sleep infinity environment: - SHELL=/bin/bash