refactor: build only one frappe/erpnext image (#1032)

* ci: skip frappe builds

* refactor: build only one frappe/erpnext image

* fix: lint nginx entrypoint script

* docs: update and organize docs

* docs: fix lint errors

* fix(custom): pass base64 encoded apps json

* ci: update dependabot

* docs: update contributing

* docs: remove info about multi image setup

* fix: initiate empty common_site_config.json

default config has host keys set to localhost
causes connection errors

* docs: add details for pwd volumes

* fix: symlink assets instead of copy

* fix: nginx private files

* ci: skip docker compose v2 install for ubuntu-latest

* fix: organize layers

* feat: allow remove git remote for custom image

* docs: allow remove git remote for custom image

* fix: remove duplicate --apps_path

tests/compose.ci-erpnext.yaml

@@ -1,24 +0,0 @@
-services:
-  configurator:
-    image: localhost:5000/frappe/erpnext-worker:${ERPNEXT_VERSION}
-
-  backend:
-    image: localhost:5000/frappe/erpnext-worker:${ERPNEXT_VERSION}
-
-  frontend:
-    image: localhost:5000/frappe/erpnext-nginx:${ERPNEXT_VERSION}
-
-  websocket:
-    image: localhost:5000/frappe/frappe-socketio:${FRAPPE_VERSION}
-
-  queue-short:
-    image: localhost:5000/frappe/erpnext-worker:${ERPNEXT_VERSION}
-
-  queue-default:
-    image: localhost:5000/frappe/erpnext-worker:${ERPNEXT_VERSION}
-
-  queue-long:
-    image: localhost:5000/frappe/erpnext-worker:${ERPNEXT_VERSION}
-
-  scheduler:
-    image: localhost:5000/frappe/erpnext-worker:${ERPNEXT_VERSION}

tests/compose.ci.yaml

@@ -1,24 +1,24 @@
 services:
   configurator:
-    image: localhost:5000/frappe/frappe-worker:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   backend:
-    image: localhost:5000/frappe/frappe-worker:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   frontend:
-    image: localhost:5000/frappe/frappe-nginx:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   websocket:
-    image: localhost:5000/frappe/frappe-socketio:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   queue-short:
-    image: localhost:5000/frappe/frappe-worker:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   queue-default:
-    image: localhost:5000/frappe/frappe-worker:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   queue-long:
-    image: localhost:5000/frappe/frappe-worker:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}
 
   scheduler:
-    image: localhost:5000/frappe/frappe-worker:${FRAPPE_VERSION}
+    image: localhost:5000/frappe/erpnext:${ERPNEXT_VERSION}

tests/conftest.py

@@ -55,11 +55,12 @@ def frappe_site(compose: Compose):
     site_name = "tests"
     compose.bench(
         "new-site",
-        site_name,
+        "--no-mariadb-socket",
         "--mariadb-root-password",
         "123",
         "--admin-password",
         "admin",
+        site_name,
     )
     compose("restart", "backend")
     yield site_name
@@ -68,11 +69,7 @@ def frappe_site(compose: Compose):
 @pytest.fixture(scope="class")
 def erpnext_setup(compose: Compose):
     compose.stop()
-
-    args = ["-f", "overrides/compose.erpnext.yaml"]
-    if CI:
-        args += ("-f", "tests/compose.ci-erpnext.yaml")
-    compose(*args, "up", "-d", "--quiet-pull")
+    compose("up", "-d", "--quiet-pull")
 
     yield
     compose.stop()
@@ -83,13 +80,14 @@ def erpnext_site(compose: Compose):
     site_name = "test_erpnext_site"
     args = [
         "new-site",
-        site_name,
+        "--no-mariadb-socket",
         "--mariadb-root-password",
         "123",
         "--admin-password",
         "admin",
         "--install-app",
         "erpnext",
+        site_name,
     ]
     erpnext_version = os.environ.get("ERPNEXT_VERSION")
     if erpnext_version in [

tests/test_frappe_docker.py

@@ -89,7 +89,13 @@ def test_frappe_connections_in_backends(
 ):
     filename = "_ping_frappe_connections.py"
     compose("cp", f"tests/{filename}", f"{service}:/tmp/")
-    compose.exec(service, python_path, f"/tmp/{filename}")
+    compose.exec(
+        "-w",
+        "/home/frappe/frappe-bench/sites",
+        service,
+        python_path,
+        f"/tmp/{filename}",
+    )
 
 
 def test_push_backup(