refactor(core): Move static data handling to workflow service (no-changelog) (#7104)

This commit is contained in:
Iván Ovejero
2023-09-05 13:42:31 +02:00
committed by GitHub
parent 011ee2e04b
commit 0036a4726c
5 changed files with 53 additions and 52 deletions

View File

@@ -45,7 +45,6 @@ import type {
} from '@/Interfaces';
import * as ResponseHelper from '@/ResponseHelper';
import * as WebhookHelpers from '@/WebhookHelpers';
import * as WorkflowHelpers from '@/WorkflowHelpers';
import * as WorkflowExecuteAdditionalData from '@/WorkflowExecuteAdditionalData';
import config from '@/config';
@@ -444,7 +443,7 @@ export class ActiveWorkflowRunner implements IWebhookManager {
}
await this.webhookService.populateCache();
// Save static data!
await WorkflowHelpers.saveStaticData(workflow);
await WorkflowsService.saveStaticData(workflow);
}
/**
@@ -483,7 +482,7 @@ export class ActiveWorkflowRunner implements IWebhookManager {
await workflow.deleteWebhook(webhookData, NodeExecuteFunctions, mode, 'update', false);
}
await WorkflowHelpers.saveStaticData(workflow);
await WorkflowsService.saveStaticData(workflow);
await this.webhookService.deleteWorkflowWebhooks(workflowId);
}
@@ -561,7 +560,7 @@ export class ActiveWorkflowRunner implements IWebhookManager {
donePromise?: IDeferredPromise<IRun | undefined>,
): void => {
Logger.debug(`Received event to trigger execution for workflow "${workflow.name}"`);
void WorkflowHelpers.saveStaticData(workflow);
void WorkflowsService.saveStaticData(workflow);
const executePromise = this.runWorkflow(
workflowData,
node,
@@ -617,7 +616,7 @@ export class ActiveWorkflowRunner implements IWebhookManager {
donePromise?: IDeferredPromise<IRun | undefined>,
): void => {
Logger.debug(`Received trigger for workflow "${workflow.name}"`);
void WorkflowHelpers.saveStaticData(workflow);
void WorkflowsService.saveStaticData(workflow);
const executePromise = this.runWorkflow(
workflowData,
@@ -814,7 +813,7 @@ export class ActiveWorkflowRunner implements IWebhookManager {
// If for example webhooks get created it sometimes has to save the
// id of them in the static data. So make sure that data gets persisted.
await WorkflowHelpers.saveStaticData(workflowInstance!);
await WorkflowsService.saveStaticData(workflowInstance!);
}
/**