From 044022f00404232051721eb741857bb7a50b8fdf Mon Sep 17 00:00:00 2001 From: Michael Kret <88898367+michael-radency@users.noreply.github.com> Date: Thu, 3 Jul 2025 14:13:45 +0300 Subject: [PATCH] fix: Evaluation nodes - add missing test function and credentialTest to methods (#16734) --- .../nodes/Evaluation/Evaluation/Evaluation.node.ee.ts | 4 ++-- .../EvaluationTrigger/EvaluationTrigger.node.ee.ts | 4 ++-- packages/nodes-base/nodes/Evaluation/methods/index.ts | 1 + .../nodes-base/nodes/Evaluation/test/Evaluation.node.test.ts | 5 +++++ .../nodes/Evaluation/test/EvaluationTrigger.node.test.ts | 5 +++++ 5 files changed, 15 insertions(+), 4 deletions(-) diff --git a/packages/nodes-base/nodes/Evaluation/Evaluation/Evaluation.node.ee.ts b/packages/nodes-base/nodes/Evaluation/Evaluation/Evaluation.node.ee.ts index 86b9c27e34..1c6893309a 100644 --- a/packages/nodes-base/nodes/Evaluation/Evaluation/Evaluation.node.ee.ts +++ b/packages/nodes-base/nodes/Evaluation/Evaluation/Evaluation.node.ee.ts @@ -13,7 +13,7 @@ import { setOutputProperties, } from './Description.node'; import { authentication } from '../../Google/Sheet/v2/actions/versionDescription'; -import { listSearch, loadOptions } from '../methods'; +import { listSearch, loadOptions, credentialTest } from '../methods'; import { checkIfEvaluating, setMetrics, setOutputs, setOutput } from '../utils/evaluationUtils'; export class Evaluation implements INodeType { @@ -87,7 +87,7 @@ export class Evaluation implements INodeType { ], }; - methods = { loadOptions, listSearch }; + methods = { loadOptions, listSearch, credentialTest }; async execute(this: IExecuteFunctions): Promise { const operation = this.getNodeParameter('operation', 0); diff --git a/packages/nodes-base/nodes/Evaluation/EvaluationTrigger/EvaluationTrigger.node.ee.ts b/packages/nodes-base/nodes/Evaluation/EvaluationTrigger/EvaluationTrigger.node.ee.ts index 696c7f59ae..149aa996e1 100644 --- a/packages/nodes-base/nodes/Evaluation/EvaluationTrigger/EvaluationTrigger.node.ee.ts +++ b/packages/nodes-base/nodes/Evaluation/EvaluationTrigger/EvaluationTrigger.node.ee.ts @@ -12,7 +12,7 @@ import { document, sheet } from '../../Google/Sheet/GoogleSheetsTrigger.node'; import { readFilter } from '../../Google/Sheet/v2/actions/sheet/read.operation'; import { authentication } from '../../Google/Sheet/v2/actions/versionDescription'; import type { ILookupValues } from '../../Google/Sheet/v2/helpers/GoogleSheets.types'; -import { listSearch, loadOptions } from '../methods'; +import { listSearch, loadOptions, credentialTest } from '../methods'; import { getGoogleSheet, getResults, @@ -106,7 +106,7 @@ export class EvaluationTrigger implements INodeType { ], }; - methods = { loadOptions, listSearch }; + methods = { loadOptions, listSearch, credentialTest }; async execute(this: IExecuteFunctions): Promise { const inputData = this.getInputData(); diff --git a/packages/nodes-base/nodes/Evaluation/methods/index.ts b/packages/nodes-base/nodes/Evaluation/methods/index.ts index 5e66ef4e08..f4984f8f8d 100644 --- a/packages/nodes-base/nodes/Evaluation/methods/index.ts +++ b/packages/nodes-base/nodes/Evaluation/methods/index.ts @@ -1,2 +1,3 @@ export * as loadOptions from './loadOptions'; export * as listSearch from './../../Google/Sheet/v2/methods/listSearch'; +export * as credentialTest from './../../Google/Sheet/v2/methods/credentialTest'; diff --git a/packages/nodes-base/nodes/Evaluation/test/Evaluation.node.test.ts b/packages/nodes-base/nodes/Evaluation/test/Evaluation.node.test.ts index 00b3a5d128..708db7651e 100644 --- a/packages/nodes-base/nodes/Evaluation/test/Evaluation.node.test.ts +++ b/packages/nodes-base/nodes/Evaluation/test/Evaluation.node.test.ts @@ -44,6 +44,11 @@ describe('Test Evaluation', () => { return { sheetId: 1, title: sheetName }; }); + test('credential test for googleApi should be in methods', async () => { + const evaluationNode = new Evaluation(); + expect(evaluationNode.methods.credentialTest.googleApiCredentialTest).toBeDefined(); + }); + test('should throw error if output values is empty', async () => { mockExecuteFunctions.getNodeParameter.mockImplementation( (key: string, _: number, fallbackValue?: string | number | boolean | object) => { diff --git a/packages/nodes-base/nodes/Evaluation/test/EvaluationTrigger.node.test.ts b/packages/nodes-base/nodes/Evaluation/test/EvaluationTrigger.node.test.ts index 7be9b62285..001acd2bb4 100644 --- a/packages/nodes-base/nodes/Evaluation/test/EvaluationTrigger.node.test.ts +++ b/packages/nodes-base/nodes/Evaluation/test/EvaluationTrigger.node.test.ts @@ -53,6 +53,11 @@ describe('Evaluation Trigger Node', () => { }); }); + test('credential test for googleApi should be in methods', async () => { + const evaluationTrigger = new EvaluationTrigger(); + expect(evaluationTrigger.methods.credentialTest.googleApiCredentialTest).toBeDefined(); + }); + test('should return a single row from google sheet', async () => { mockExecuteFunctions.getNodeParameter.mockImplementation( (key: string, _: number, fallbackValue?: string | number | boolean | object) => {