refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules (#3174)

*  Initial setup

* 👕 Update `.eslintignore`

* 👕 Autofix node-param-default-missing (#3173)

* 🔥 Remove duplicate key

* 👕 Add exceptions

* 📦 Update package-lock.json

* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176)

* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177)

* 👕 Apply `node-class-description-outputs-wrong` (#3178)

* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179)

* 👕 Apply `node-param-default-wrong-for-collection` (#3180)

* 👕 Apply node-param-default-wrong-for-boolean (#3181)

* Autofixed default missing

* Autofixed booleans, worked well

*  Fix params

*  Undo exempted autofixes

* 📦 Update package-lock.json

* 👕 Apply node-class-description-missing-subtitle (#3182)

*  Fix missing comma

* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184)

* 👕 Add exception for `node-class-description-missing-subtitle`

* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185)

* 👕 Apply `node-param-collection-type-unsorted-items` (#3186)

* Missing coma

* 👕 Apply `node-param-default-wrong-for-simplify` (#3187)

* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190)

* 👕 Apply `node-param-description-empty-string` (#3189)

* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191)

* Rule looks good

* Add whitespace rule in eslint config

* :zao: fix

* 👕 Apply `node-param-description-identical-to-display-name` (#3193)

* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195)

*  Revert ":zao: fix"

This reverts commit ef8a76f3dfedffd1bdccf3178af8a8d90cf5a55c.

* 👕 Apply `node-param-description-missing-for-simplify`  (#3196)

* 👕 Apply `node-param-description-missing-final-period` (#3194)

* Rule working as intended

* Add rule to eslint

* 👕 Apply node-param-description-missing-for-return-all (#3197)

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero
2022-04-22 18:29:51 +02:00
committed by GitHub
parent aeb5a1234a
commit 0448feec56
408 changed files with 2591 additions and 2026 deletions

View File

@@ -195,8 +195,7 @@ export const conversationFields: INodeProperties[] = [
name: 'autoReply',
type: 'boolean',
default: false,
description: `When autoReply is set to true, an auto reply will be sent
as long as there is at least one customer thread in the conversation.`,
description: 'When autoReply is set to true, an auto reply will be sent as long as there is at least one customer thread in the conversation.',
},
{
displayName: 'Closed At',
@@ -385,7 +384,6 @@ export const conversationFields: INodeProperties[] = [
],
},
},
description: 'conversation ID',
},
/* -------------------------------------------------------------------------- */
/* conversation:delete */
@@ -406,7 +404,6 @@ export const conversationFields: INodeProperties[] = [
],
},
},
description: 'conversation ID',
},
/* -------------------------------------------------------------------------- */
/* conversation:getAll */

View File

@@ -149,14 +149,12 @@ export const customerFields: INodeProperties[] = [
alwaysOpenEditWindow: true,
},
default: '',
description: `Notes`,
},
{
displayName: 'Organization',
name: 'organization',
type: 'string',
default: '',
description: 'Organization',
},
{
displayName: 'Photo Url',
@@ -207,14 +205,12 @@ export const customerFields: INodeProperties[] = [
name: 'city',
type: 'string',
default: '',
description: 'City',
},
{
displayName: 'State',
name: 'state',
type: 'string',
default: '',
description: 'State',
},
{
displayName: 'Country',
@@ -224,14 +220,12 @@ export const customerFields: INodeProperties[] = [
loadOptionsMethod: 'getCountriesCodes',
},
default: '',
description: 'Country',
},
{
displayName: 'Postal Code',
name: 'postalCode',
type: 'string',
default: '',
description: 'Postal code',
},
],
},
@@ -724,7 +718,6 @@ export const customerFields: INodeProperties[] = [
],
},
},
description: 'Customer ID',
},
/* -------------------------------------------------------------------------- */
/* customer:update */
@@ -744,7 +737,6 @@ export const customerFields: INodeProperties[] = [
],
},
},
description: 'Customer ID',
},
{
displayName: 'Update Fields',
@@ -830,14 +822,12 @@ export const customerFields: INodeProperties[] = [
alwaysOpenEditWindow: true,
},
default: '',
description: `Notes`,
},
{
displayName: 'Organization',
name: 'organization',
type: 'string',
default: '',
description: 'Organization',
},
{
displayName: 'Photo Url',

View File

@@ -165,7 +165,7 @@ export class HelpScout implements INodeType {
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
const items = this.getInputData();
const returnData: IDataObject[] = [];
const length = items.length as unknown as number;
const length = items.length;
const qs: IDataObject = {};
let responseData;
const resource = this.getNodeParameter('resource', 0) as string;

View File

@@ -49,7 +49,6 @@ export const threadFields: INodeProperties[] = [
],
},
},
description: 'conversation ID',
},
{
displayName: 'Type',
@@ -230,7 +229,7 @@ export const threadFields: INodeProperties[] = [
],
},
],
default: '',
default: {},
description: 'Array of supported attachments to add to the message.',
},
/* -------------------------------------------------------------------------- */
@@ -252,7 +251,6 @@ export const threadFields: INodeProperties[] = [
],
},
},
description: 'conversation ID',
},
{
displayName: 'Return All',