refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules (#3174)

*  Initial setup

* 👕 Update `.eslintignore`

* 👕 Autofix node-param-default-missing (#3173)

* 🔥 Remove duplicate key

* 👕 Add exceptions

* 📦 Update package-lock.json

* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176)

* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177)

* 👕 Apply `node-class-description-outputs-wrong` (#3178)

* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179)

* 👕 Apply `node-param-default-wrong-for-collection` (#3180)

* 👕 Apply node-param-default-wrong-for-boolean (#3181)

* Autofixed default missing

* Autofixed booleans, worked well

*  Fix params

*  Undo exempted autofixes

* 📦 Update package-lock.json

* 👕 Apply node-class-description-missing-subtitle (#3182)

*  Fix missing comma

* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184)

* 👕 Add exception for `node-class-description-missing-subtitle`

* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185)

* 👕 Apply `node-param-collection-type-unsorted-items` (#3186)

* Missing coma

* 👕 Apply `node-param-default-wrong-for-simplify` (#3187)

* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190)

* 👕 Apply `node-param-description-empty-string` (#3189)

* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191)

* Rule looks good

* Add whitespace rule in eslint config

* :zao: fix

* 👕 Apply `node-param-description-identical-to-display-name` (#3193)

* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195)

*  Revert ":zao: fix"

This reverts commit ef8a76f3dfedffd1bdccf3178af8a8d90cf5a55c.

* 👕 Apply `node-param-description-missing-for-simplify`  (#3196)

* 👕 Apply `node-param-description-missing-final-period` (#3194)

* Rule working as intended

* Add rule to eslint

* 👕 Apply node-param-description-missing-for-return-all (#3197)

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero
2022-04-22 18:29:51 +02:00
committed by GitHub
parent aeb5a1234a
commit 0448feec56
408 changed files with 2591 additions and 2026 deletions

View File

@@ -106,7 +106,7 @@ export const companyFields: INodeProperties[] = [
typeOptions: {
multipleValues: false,
},
default: '',
default: {},
placeholder: 'Add Address',
displayOptions: {
show: {
@@ -366,7 +366,7 @@ export const companyFields: INodeProperties[] = [
name: 'fields',
type: 'string',
default: '',
description: `Comma-delimited list of Company properties to include in the response. (Fields such as notes, fax_number and custom_fields aren't included, by default.)`,
description: 'Comma-delimited list of Company properties to include in the response. (Fields such as notes, fax_number and custom_fields aren\'t included, by default.).',
},
],
},

View File

@@ -72,7 +72,7 @@ export const contactFields: INodeProperties[] = [
},
},
default: 'email',
description: `Performs duplicate checking by one of the following options: Email, EmailAndName. If a match is found using the option provided, the existing contact will be updated`,
description: 'Performs duplicate checking by one of the following options: Email, EmailAndName. If a match is found using the option provided, the existing contact will be updated.',
},
{
displayName: 'Additional Fields',
@@ -241,7 +241,7 @@ export const contactFields: INodeProperties[] = [
typeOptions: {
multipleValues: true,
},
default: '',
default: {},
placeholder: 'Add Address',
displayOptions: {
show: {
@@ -506,7 +506,7 @@ export const contactFields: INodeProperties[] = [
typeOptions: {
multipleValues: true,
},
default: '',
default: {},
placeholder: 'Add Social Account',
displayOptions: {
show: {
@@ -615,7 +615,7 @@ export const contactFields: INodeProperties[] = [
name: 'fields',
type: 'string',
default: '',
description: `Comma-delimited list of Contact properties to include in the response. (Some fields such as lead_source_id, custom_fields, and job_title aren't included, by default.)`,
description: 'Comma-delimited list of Contact properties to include in the response. (Some fields such as lead_source_id, custom_fields, and job_title aren\'t included, by default.).',
},
],
},

View File

@@ -175,7 +175,7 @@ export const ecommerceOrderFields: INodeProperties[] = [
typeOptions: {
multipleValues: false,
},
default: '',
default: {},
placeholder: 'Add Address',
displayOptions: {
show: {

View File

@@ -341,7 +341,7 @@ export const emailFields: INodeProperties[] = [
},
},
default: '',
description: 'Contact Ids to receive the email. Multiple can be added seperated by comma',
description: 'Contact Ids to receive the email. Multiple can be added seperated by comma.',
},
{
displayName: 'Subject',
@@ -456,7 +456,7 @@ export const emailFields: INodeProperties[] = [
],
},
],
default: '',
default: {},
description: 'Attachments to be sent with each copy of the email, maximum of 10 with size of 1MB each',
},
];

View File

@@ -289,7 +289,7 @@ export class Keap implements INodeType {
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
const items = this.getInputData();
const returnData: IDataObject[] = [];
const length = items.length as unknown as number;
const length = items.length;
const qs: IDataObject = {};
let responseData;
const resource = this.getNodeParameter('resource', 0) as string;