refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules (#3174)

*  Initial setup

* 👕 Update `.eslintignore`

* 👕 Autofix node-param-default-missing (#3173)

* 🔥 Remove duplicate key

* 👕 Add exceptions

* 📦 Update package-lock.json

* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176)

* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177)

* 👕 Apply `node-class-description-outputs-wrong` (#3178)

* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179)

* 👕 Apply `node-param-default-wrong-for-collection` (#3180)

* 👕 Apply node-param-default-wrong-for-boolean (#3181)

* Autofixed default missing

* Autofixed booleans, worked well

*  Fix params

*  Undo exempted autofixes

* 📦 Update package-lock.json

* 👕 Apply node-class-description-missing-subtitle (#3182)

*  Fix missing comma

* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184)

* 👕 Add exception for `node-class-description-missing-subtitle`

* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185)

* 👕 Apply `node-param-collection-type-unsorted-items` (#3186)

* Missing coma

* 👕 Apply `node-param-default-wrong-for-simplify` (#3187)

* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190)

* 👕 Apply `node-param-description-empty-string` (#3189)

* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191)

* Rule looks good

* Add whitespace rule in eslint config

* :zao: fix

* 👕 Apply `node-param-description-identical-to-display-name` (#3193)

* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195)

*  Revert ":zao: fix"

This reverts commit ef8a76f3dfedffd1bdccf3178af8a8d90cf5a55c.

* 👕 Apply `node-param-description-missing-for-simplify`  (#3196)

* 👕 Apply `node-param-description-missing-final-period` (#3194)

* Rule working as intended

* Add rule to eslint

* 👕 Apply node-param-description-missing-for-return-all (#3197)

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero
2022-04-22 18:29:51 +02:00
committed by GitHub
parent aeb5a1234a
commit 0448feec56
408 changed files with 2591 additions and 2026 deletions

View File

@@ -106,7 +106,7 @@ export const accountFields: INodeProperties[] = [
],
},
},
description: `If this value exists in the 'match against' field, update the account. Otherwise create a new one`,
description: 'If this value exists in the \'match against\' field, update the account. Otherwise create a new one.',
},
{
displayName: 'Name',
@@ -279,7 +279,6 @@ export const accountFields: INodeProperties[] = [
name: 'numberOfEmployees',
type: 'number',
default: '',
description: 'Number of employees',
},
{
displayName: 'Owner',
@@ -339,7 +338,7 @@ export const accountFields: INodeProperties[] = [
name: 'shippingCity',
type: 'string',
default: '',
description: 'Details of the shipping address for this account. City maximum size is 40 characters',
description: 'Details of the shipping address for this account. City maximum size is 40 characters.',
},
{
displayName: 'Shipping Country',
@@ -594,7 +593,6 @@ export const accountFields: INodeProperties[] = [
name: 'numberOfEmployees',
type: 'number',
default: '',
description: 'Number of employees',
},
{
displayName: 'Parent ID',
@@ -618,7 +616,7 @@ export const accountFields: INodeProperties[] = [
name: 'shippingCity',
type: 'string',
default: '',
description: 'Details of the shipping address for this account. City maximum size is 40 characters',
description: 'Details of the shipping address for this account. City maximum size is 40 characters.',
},
{
displayName: 'Shipping Country',

View File

@@ -72,7 +72,6 @@ export const attachmentFields: INodeProperties[] = [
],
},
},
description: '',
},
{
displayName: 'Name',

View File

@@ -253,7 +253,7 @@ export const caseFields: INodeProperties[] = [
name: 'suppliedName',
type: 'string',
default: '',
description: `The name that was entered when the case was created. This field can't be updated after the case has been created`,
description: 'The name that was entered when the case was created. This field can\'t be updated after the case has been created.',
},
{
displayName: 'Supplied Phone',
@@ -459,7 +459,7 @@ export const caseFields: INodeProperties[] = [
name: 'suppliedName',
type: 'string',
default: '',
description: `The name that was entered when the case was created. This field can't be updated after the case has been created`,
description: 'The name that was entered when the case was created. This field can\'t be updated after the case has been created.',
},
{
displayName: 'Supplied Phone',

View File

@@ -111,7 +111,7 @@ export const contactFields: INodeProperties[] = [
],
},
},
description: `If this value exists in the 'match against' field, update the contact. Otherwise create a new one`,
description: 'If this value exists in the \'match against\' field, update the contact. Otherwise create a new one.',
},
{
displayName: 'Last Name',
@@ -278,8 +278,7 @@ export const contactFields: INodeProperties[] = [
name: 'jigsaw',
type: 'string',
default: '',
description: `references the ID of a contact in Data.com.
If a contact has a value in this field, it means that a contact was imported as a contact from Data.com.`,
description: 'references the ID of a contact in Data.com. If a contact has a value in this field, it means that a contact was imported as a contact from Data.com.',
},
{
displayName: 'Lead Source',
@@ -576,8 +575,7 @@ export const contactFields: INodeProperties[] = [
name: 'jigsaw',
type: 'string',
default: '',
description: `references the ID of a contact in Data.com.
If a contact has a value in this field, it means that a contact was imported as a contact from Data.com.`,
description: 'references the ID of a contact in Data.com. If a contact has a value in this field, it means that a contact was imported as a contact from Data.com.',
},
{
displayName: 'Last Name',

View File

@@ -118,7 +118,7 @@ export const customObjectFields: INodeProperties[] = [
],
},
},
description: `If this value exists in the 'match against' field, update the object. Otherwise create a new one`,
description: 'If this value exists in the \'match against\' field, update the object. Otherwise create a new one.',
},
{
displayName: 'Fields',
@@ -507,7 +507,7 @@ export const customObjectFields: INodeProperties[] = [
'customObject',
],
},
default: '',
default: [],
description: 'Fields to include separated by ,',
},
],

View File

@@ -111,7 +111,7 @@ export const leadFields: INodeProperties[] = [
],
},
},
description: `If this value exists in the 'match against' field, update the lead. Otherwise create a new one`,
description: 'If this value exists in the \'match against\' field, update the lead. Otherwise create a new one.',
},
{
displayName: 'Company',
@@ -265,8 +265,7 @@ export const leadFields: INodeProperties[] = [
name: 'jigsaw',
type: 'string',
default: '',
description: `references the ID of a contact in Data.com.
If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.`,
description: 'references the ID of a contact in Data.com. If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.',
},
{
displayName: 'Lead Source',
@@ -521,8 +520,7 @@ export const leadFields: INodeProperties[] = [
name: 'jigsaw',
type: 'string',
default: '',
description: `references the ID of a contact in Data.com.
If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.`,
description: 'references the ID of a contact in Data.com. If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.',
},
{
displayName: 'Last Name',

View File

@@ -106,7 +106,7 @@ export const opportunityFields: INodeProperties[] = [
],
},
},
description: `If this value exists in the 'match against' field, update the opportunity. Otherwise create a new one`,
description: 'If this value exists in the \'match against\' field, update the opportunity. Otherwise create a new one.',
},
{
displayName: 'Name',

View File

@@ -109,17 +109,14 @@ export const taskFields: INodeProperties[] = [
alwaysOpenEditWindow: true,
},
default: '',
description: `Represents the result of a given call, for example, “we'll call back,” or “call
unsuccessful.” Limit is 255 characters. Not subject to field-level security, available for any user
in an organization with Salesforce CRM Call Center.`,
description: 'Represents the result of a given call, for example, “we\'ll call back,” or “call unsuccessful.” Limit is 255 characters. Not subject to field-level security, available for any user in an organization with Salesforce CRM Call Center.',
},
{
displayName: 'Call Duration In Seconds',
name: 'callDurationInSeconds',
type: 'number',
default: '',
description: `Duration of the call in seconds. Not subject to field-level security,
available for any user in an organization with Salesforce CRM Call Center`,
description: 'Duration of the call in seconds. Not subject to field-level security, available for any user in an organization with Salesforce CRM Call Center',
},
{
displayName: 'Call Object',
@@ -232,7 +229,7 @@ export const taskFields: INodeProperties[] = [
loadOptionsMethod: 'getTaskRecurrenceInstances',
},
default: '',
description: `The frequency of the recurring task. For example, “2nd” or “3rd.”`,
description: 'The frequency of the recurring task. For example, “2nd” or “3rd.”.',
},
{
displayName: 'Recurrence Interval',
@@ -260,8 +257,7 @@ export const taskFields: INodeProperties[] = [
name: 'recurrenceEndDateOnly',
type: 'dateTime',
default: '',
description: `The last date on which the task repeats. This field has a timestamp that
is always set to midnight in the Coordinated Universal Time (UTC) time zone.`,
description: 'The last date on which the task repeats. This field has a timestamp that is always set to midnight in the Coordinated Universal Time (UTC) time zone.',
},
{
displayName: 'Recurrence Month Of Year',
@@ -360,10 +356,7 @@ export const taskFields: INodeProperties[] = [
name: 'reminderDateTime',
type: 'dateTime',
default: '',
description: `Represents the time when the reminder is scheduled to fire,
if IsReminderSet is set to true. If IsReminderSet is set to false, then the
user may have deselected the reminder checkbox in the Salesforce user interface,
or the reminder has already fired at the time indicated by the value.`,
description: 'Represents the time when the reminder is scheduled to fire, if IsReminderSet is set to true. If IsReminderSet is set to false, then the user may have deselected the reminder checkbox in the Salesforce user interface, or the reminder has already fired at the time indicated by the value.',
},
{
displayName: 'Subject',
@@ -390,9 +383,7 @@ export const taskFields: INodeProperties[] = [
name: 'whatId',
type: 'string',
default: '',
description: `The WhatId represents nonhuman objects such as accounts, opportunities,
campaigns, cases, or custom objects. WhatIds are polymorphic. Polymorphic means a
WhatId is equivalent to the ID of a related object.`,
description: 'The WhatId represents nonhuman objects such as accounts, opportunities, campaigns, cases, or custom objects. WhatIds are polymorphic. Polymorphic means a WhatId is equivalent to the ID of a related object.',
},
{
displayName: 'Who Id',
@@ -457,17 +448,14 @@ export const taskFields: INodeProperties[] = [
alwaysOpenEditWindow: true,
},
default: '',
description: `Represents the result of a given call, for example, “we'll call back,” or “call
unsuccessful.” Limit is 255 characters. Not subject to field-level security, available for any user
in an organization with Salesforce CRM Call Center.`,
description: 'Represents the result of a given call, for example, “we\'ll call back,” or “call unsuccessful.” Limit is 255 characters. Not subject to field-level security, available for any user in an organization with Salesforce CRM Call Center.',
},
{
displayName: 'Call Duration In Seconds',
name: 'callDurationInSeconds',
type: 'number',
default: '',
description: `Duration of the call in seconds. Not subject to field-level security,
available for any user in an organization with Salesforce CRM Call Center`,
description: 'Duration of the call in seconds. Not subject to field-level security, available for any user in an organization with Salesforce CRM Call Center',
},
{
displayName: 'Call Object',
@@ -601,8 +589,7 @@ export const taskFields: INodeProperties[] = [
name: 'recurrenceEndDateOnly',
type: 'dateTime',
default: '',
description: `The last date on which the task repeats. This field has a timestamp that
is always set to midnight in the Coordinated Universal Time (UTC) time zone.`,
description: 'The last date on which the task repeats. This field has a timestamp that is always set to midnight in the Coordinated Universal Time (UTC) time zone.',
},
{
displayName: 'Recurrence Instance',
@@ -612,7 +599,7 @@ export const taskFields: INodeProperties[] = [
loadOptionsMethod: 'getTaskRecurrenceInstances',
},
default: '',
description: `The frequency of the recurring task. For example, “2nd” or “3rd.”`,
description: 'The frequency of the recurring task. For example, “2nd” or “3rd.”.',
},
{
displayName: 'Recurrence Interval',
@@ -728,10 +715,7 @@ export const taskFields: INodeProperties[] = [
name: 'reminderDateTime',
type: 'dateTime',
default: '',
description: `Represents the time when the reminder is scheduled to fire,
if IsReminderSet is set to true. If IsReminderSet is set to false, then the
user may have deselected the reminder checkbox in the Salesforce user interface,
or the reminder has already fired at the time indicated by the value.`,
description: 'Represents the time when the reminder is scheduled to fire, if IsReminderSet is set to true. If IsReminderSet is set to false, then the user may have deselected the reminder checkbox in the Salesforce user interface, or the reminder has already fired at the time indicated by the value.',
},
{
displayName: 'Type',
@@ -748,9 +732,7 @@ export const taskFields: INodeProperties[] = [
name: 'whatId',
type: 'string',
default: '',
description: `The WhatId represents nonhuman objects such as accounts, opportunities,
campaigns, cases, or custom objects. WhatIds are polymorphic. Polymorphic means a
WhatId is equivalent to the ID of a related object.`,
description: 'The WhatId represents nonhuman objects such as accounts, opportunities, campaigns, cases, or custom objects. WhatIds are polymorphic. Polymorphic means a WhatId is equivalent to the ID of a related object.',
},
{
displayName: 'Who Id',