From 052dd7cc9d10b2365b38001c6e091bd52bf45873 Mon Sep 17 00:00:00 2001 From: Marcus <56945030+maspio@users.noreply.github.com> Date: Fri, 18 Aug 2023 14:38:41 +0200 Subject: [PATCH] fix(Google Sheets Trigger Node): Support sheet names with non-latin characters (#6970) Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/how-to-get-new-rows-in-google-sheets/25810 --- .../nodes/Google/Sheet/GoogleSheetsTrigger.node.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts b/packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts index 390e8773a7..45fe4aa16c 100644 --- a/packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts +++ b/packages/nodes-base/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts @@ -418,7 +418,7 @@ export class GoogleSheetsTrigger implements INodeType { } const googleSheet = new GoogleSheet(documentId, this); - const sheetName = await googleSheet.spreadsheetGetSheetNameById(sheetId); + const sheetName: string = await googleSheet.spreadsheetGetSheetNameById(sheetId); const options = this.getNodeParameter('options') as IDataObject; const previousRevision = workflowStaticData.lastRevision as number; @@ -510,7 +510,7 @@ export class GoogleSheetsTrigger implements INodeType { (await apiRequest.call( this, 'GET', - `/v4/spreadsheets/${documentId}/values/${sheetName}!${keyRange}`, + `/v4/spreadsheets/${documentId}/values/${encodeURIComponent(sheetName)}!${keyRange}`, )) as IDataObject ).values as string[][]) || [[]]; @@ -596,7 +596,7 @@ export class GoogleSheetsTrigger implements INodeType { const previousRevisionSheetData = sheetBinaryToArrayOfArrays( previousRevisionBinaryData, - sheetName as string, + sheetName, rangeDefinition === 'specifyRangeA1' ? range : undefined, ) || [];