admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Redact credentials (#13263)

Browse Source
This commit is contained in:
Tomi Turtiainen
2025-02-14 16:46:21 +02:00
committed by GitHub
parent d116f121e3
commit 052f17744d
7 changed files with 157 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/cli/test/integration/credentials/credentials.api.ee.test.ts
View File

@@ -28,7 +28,10 @@ import {
createUser,
createUserShell,
} from '../shared/db/users';
import { randomCredentialPayload } from '../shared/random';
import {
randomCredentialPayload,
randomCredentialPayloadWithOauthTokenData,
} from '../shared/random';
import * as testDb from '../shared/test-db';
import type { SaveCredentialFunction } from '../shared/types';
import type { SuperAgentTest } from '../shared/types';
@@ -556,10 +559,11 @@ describe('GET /credentials/:id', () => {
expect(secondCredential.data).toBeDefined();
});
test('should not redact the data when `includeData:true` is passed', async () => {
test('should redact the data when `includeData:true` is passed', async () => {
const credentialService = Container.get(CredentialsService);
const redactSpy = jest.spyOn(credentialService, 'redact');
const savedCredential = await saveCredential(randomCredentialPayload(), {
const credential = randomCredentialPayloadWithOauthTokenData();
const savedCredential = await saveCredential(credential, {
user: owner,
});
@@ -569,7 +573,8 @@ describe('GET /credentials/:id', () => {
validateMainCredentialData(response.body.data);
expect(response.body.data.data).toBeDefined();
expect(redactSpy).not.toHaveBeenCalled();
expect(response.body.data.data.oauthTokenData).toBe(true);
expect(redactSpy).toHaveBeenCalled();
});
test('should retrieve non-owned cred for owner', async () => {