From 05360cee79d5d84302c372323244286efc0c6281 Mon Sep 17 00:00:00 2001 From: shortstacked Date: Mon, 7 Jul 2025 11:50:01 +0100 Subject: [PATCH] fix: Add install step for playwright binaries (#16945) --- package.json | 2 +- packages/testing/playwright/package.json | 3 ++- packages/testing/playwright/playwright.config.ts | 1 + turbo.json | 10 +++++++++- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index f7a1b9372d..39b5f631d7 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "build:deploy": "node scripts/build-n8n.mjs", "build:docker": "node scripts/build-n8n.mjs && node scripts/dockerize-n8n.mjs", "build:docker:scan": "node scripts/build-n8n.mjs && node scripts/dockerize-n8n.mjs && node scripts/scan-n8n-image.mjs", - "build:docker:test": "node scripts/build-n8n.mjs && node scripts/dockerize-n8n.mjs && pnpm --filter=n8n-playwright run test:standard", + "build:docker:test": "node scripts/build-n8n.mjs && node scripts/dockerize-n8n.mjs && turbo run test:standard --filter=n8n-playwright", "typecheck": "turbo typecheck", "dev": "turbo run dev --parallel --env-mode=loose --filter=!@n8n/design-system --filter=!@n8n/chat --filter=!@n8n/task-runner", "dev:be": "turbo run dev --parallel --env-mode=loose --filter=!@n8n/design-system --filter=!@n8n/chat --filter=!@n8n/task-runner --filter=!n8n-editor-ui", diff --git a/packages/testing/playwright/package.json b/packages/testing/playwright/package.json index 6decb508b5..e257d03bf5 100644 --- a/packages/testing/playwright/package.json +++ b/packages/testing/playwright/package.json @@ -12,7 +12,8 @@ "test:clean": "docker rm -f $(docker ps -aq --filter 'name=n8n-*') 2>/dev/null || true && docker network prune -f", "lint": "eslint . --quiet", "lintfix": "eslint . --fix", - "install-browsers": "PLAYWRIGHT_BROWSERS_PATH=./ms-playwright-cache playwright install chromium --with-deps" + "install-browsers:ci": "PLAYWRIGHT_BROWSERS_PATH=./ms-playwright-cache playwright install chromium --with-deps --no-shell", + "install-browsers:local": "playwright install chromium --with-deps --no-shell" }, "devDependencies": { "@currents/playwright": "1.14.1", diff --git a/packages/testing/playwright/playwright.config.ts b/packages/testing/playwright/playwright.config.ts index 6ea07f2b4a..2b9a2e14e3 100644 --- a/packages/testing/playwright/playwright.config.ts +++ b/packages/testing/playwright/playwright.config.ts @@ -117,6 +117,7 @@ export default defineConfig({ viewport: { width: 1536, height: 960 }, actionTimeout: 10000, navigationTimeout: 10000, + channel: 'chromium', }, projects: process.env.N8N_BASE_URL diff --git a/turbo.json b/turbo.json index c5b8a0f5b0..32b1a42415 100644 --- a/turbo.json +++ b/turbo.json @@ -143,11 +143,19 @@ "cache": false, "persistent": true }, - "install-browsers": { + "install-browsers:ci": { "cache": true, "inputs": ["package.json"], "outputs": ["ms-playwright-cache/**"], "env": ["PLAYWRIGHT_BROWSERS_PATH"] + }, + "install-browsers:local": { + "cache": false, + "inputs": ["package.json"] + }, + "test:standard": { + "dependsOn": ["install-browsers:local"], + "cache": false } } }