refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)

* 📘 Set up overloads

* 📘 Add temporary assertion

* 🔥 Remove inferrable number assertions

* ✏️ Add ticket ref
This commit is contained in:
Iván Ovejero
2022-11-18 15:26:22 +01:00
committed by GitHub
parent 600b285a44
commit 0565194473
166 changed files with 783 additions and 689 deletions

View File

@@ -1978,7 +1978,7 @@ export class Asana implements INodeType {
responseData = responseData.data;
if (!returnAll) {
const limit = this.getNodeParameter('limit', i) as boolean;
const limit = this.getNodeParameter('limit', i);
responseData = responseData.splice(0, limit);
}
}
@@ -2067,7 +2067,7 @@ export class Asana implements INodeType {
qs,
);
} else {
qs.limit = this.getNodeParameter('limit', i) as boolean;
qs.limit = this.getNodeParameter('limit', i);
responseData = await asanaApiRequest.call(this, requestMethod, endpoint, body, qs);
@@ -2365,7 +2365,7 @@ export class Asana implements INodeType {
qs,
);
} else {
qs.limit = this.getNodeParameter('limit', i) as boolean;
qs.limit = this.getNodeParameter('limit', i);
responseData = await asanaApiRequest.call(this, requestMethod, endpoint, body, qs);
@@ -2410,10 +2410,9 @@ export class Asana implements INodeType {
}
returnData.push(
...this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData),
{ itemData: { item: i } },
),
...this.helpers.constructExecutionMetaData(this.helpers.returnJsonArray(responseData), {
itemData: { item: i },
}),
);
} catch (error) {
if (this.continueOnFail()) {