refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)

* 📘 Set up overloads

* 📘 Add temporary assertion

* 🔥 Remove inferrable number assertions

* ✏️ Add ticket ref
This commit is contained in:
Iván Ovejero
2022-11-18 15:26:22 +01:00
committed by GitHub
parent 600b285a44
commit 0565194473
166 changed files with 783 additions and 689 deletions

View File

@@ -244,7 +244,7 @@ export class Intercom implements INodeType {
qs,
);
} else {
qs.per_page = this.getNodeParameter('limit', i) as number;
qs.per_page = this.getNodeParameter('limit', i);
responseData = await intercomApiRequest.call(this, '/contacts', 'GET', {}, qs);
responseData = responseData.contacts;
}
@@ -419,7 +419,7 @@ export class Intercom implements INodeType {
qs,
);
} else {
qs.per_page = this.getNodeParameter('limit', i) as number;
qs.per_page = this.getNodeParameter('limit', i);
responseData = await intercomApiRequest.call(this, '/users', 'GET', {}, qs);
responseData = responseData.users;
}
@@ -543,7 +543,7 @@ export class Intercom implements INodeType {
qs,
);
} else {
qs.per_page = this.getNodeParameter('limit', i) as number;
qs.per_page = this.getNodeParameter('limit', i);
responseData = await intercomApiRequest.call(this, '/companies', 'GET', {}, qs);
responseData = responseData.companies;
}
@@ -576,7 +576,7 @@ export class Intercom implements INodeType {
qs,
);
} else {
qs.per_page = this.getNodeParameter('limit', i) as number;
qs.per_page = this.getNodeParameter('limit', i);
responseData = await intercomApiRequest.call(
this,
`/companies/${value}/users`,
@@ -599,7 +599,7 @@ export class Intercom implements INodeType {
qs,
);
} else {
qs.per_page = this.getNodeParameter('limit', i) as number;
qs.per_page = this.getNodeParameter('limit', i);
responseData = await intercomApiRequest.call(this, '/companies', 'GET', {}, qs);
responseData = responseData.users;
}