fix(Splunk Node): Retry attempts if no response from API call, better error with suggestion to use Retry On Fail (#9176)

Co-authored-by: Elias Meire <elias@meire.dev>
This commit is contained in:
Michael Kret
2024-04-24 11:05:53 +03:00
committed by GitHub
parent 2bf0a3933e
commit 05a569c1cd
3 changed files with 189 additions and 21 deletions

View File

@@ -6,7 +6,7 @@ import type {
IRequestOptions,
IHttpRequestMethods,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';
import { NodeApiError, NodeOperationError, sleep } from 'n8n-workflow';
import { parseString } from 'xml2js';
@@ -139,9 +139,29 @@ export async function splunkApiRequest(
delete options.qs;
}
let result;
try {
return await this.helpers.request(options).then(parseXml);
let attempts = 0;
do {
try {
const response = await this.helpers.request(options);
result = await parseXml(response);
return result;
} catch (error) {
if (attempts >= 5) {
throw error;
}
await sleep(1000);
attempts++;
}
} while (true);
} catch (error) {
if (result === undefined) {
throw new NodeOperationError(this.getNode(), 'No response from API call', {
description: "Try to use 'Retry On Fail' option from node's settings",
});
}
if (error?.cause?.code === 'ECONNREFUSED') {
throw new NodeApiError(this.getNode(), { ...(error as JsonObject), code: 401 });
}