fix(core): Fix using secrets for credentials on oauth callback (#14711)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
This commit is contained in:
Guillaume Jacquart
2025-04-18 10:29:04 +02:00
committed by GitHub
parent 3641c1fb87
commit 09806c36ae
8 changed files with 23 additions and 20 deletions

View File

@@ -121,17 +121,20 @@ export abstract class AbstractOAuthController {
);
}
protected applyDefaultsAndOverwrites<T>(
protected async applyDefaultsAndOverwrites<T>(
credential: ICredentialsDb,
decryptedData: ICredentialDataDecryptedObject,
additionalData: IWorkflowExecuteAdditionalData,
) {
return this.credentialsHelper.applyDefaultsAndOverwrites(
return (await this.credentialsHelper.applyDefaultsAndOverwrites(
additionalData,
decryptedData,
credential,
credential.type,
'internal',
) as unknown as T;
undefined,
undefined,
)) as unknown as T;
}
protected async encryptAndSaveData(
@@ -209,7 +212,8 @@ export abstract class AbstractOAuthController {
credential,
additionalData,
);
const oauthCredentials = this.applyDefaultsAndOverwrites<T>(
const oauthCredentials = await this.applyDefaultsAndOverwrites<T>(
credential,
decryptedDataOriginal,
additionalData,