admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Postgres Node): Allow users to wrap strings with $$ (#12034)

Browse Source
This commit is contained in:
Dana
2024-12-16 18:02:48 +01:00
committed by GitHub
parent a5e01cfa23
commit 0c15e30778
3 changed files with 55 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
packages/nodes-base/nodes/Postgres/test/v2/operations.test.ts
View File

@@ -217,7 +217,7 @@ describe('Test PostgresV2, executeQuery operation', () => {
);
expect(runQueries).toHaveBeenCalledWith(
[{ query: 'select * from $1:name;', values: ['my_table'] }],
[{ query: 'select * from $1:name;', values: ['my_table'], options: { partial: true } }],
items,
nodeOptions,
);
@@ -239,7 +239,7 @@ describe('Test PostgresV2, executeQuery operation', () => {
);
expect(runQueries).toHaveBeenCalledWith(
[{ query: 'select $1;', values: ['$1'] }],
[{ query: 'select $1;', values: ['$1'], options: { partial: true } }],
items,
nodeOptions,
);
@@ -263,7 +263,7 @@ describe('Test PostgresV2, executeQuery operation', () => {
);
expect(runQueries).toHaveBeenCalledWith(
[{ query: "select '$1';", values: ['my_table'] }],
[{ query: "select '$1';", values: ['my_table'], options: { partial: true } }],
items,
nodeOptions,
);
@@ -288,7 +288,7 @@ describe('Test PostgresV2, executeQuery operation', () => {
);
expect(runQueries).toHaveBeenCalledWith(
[{ query: 'select $2;', values: ['my_table', '$1'] }],
[{ query: 'select $2;', values: ['my_table', '$1'], options: { partial: true } }],
items,
nodeOptions,
);
@@ -313,6 +313,54 @@ describe('Test PostgresV2, executeQuery operation', () => {
);
}).not.toThrow();
});
it('should allow users to use $$ instead of strings', async () => {
const nodeParameters: IDataObject = {
operation: 'executeQuery',
query: 'INSERT INTO dollar_bug (description) VALUES ($$34test$$);',
options: {},
};
const nodeOptions = nodeParameters.options as IDataObject;
expect(async () => {
await executeQuery.execute.call(
createMockExecuteFunction(nodeParameters),
runQueries,
items,
nodeOptions,
);
}).not.toThrow();
});
it('should allow users to use $$ instead of strings while using query parameters', async () => {
const nodeParameters: IDataObject = {
operation: 'executeQuery',
query: 'INSERT INTO dollar_bug (description) VALUES ($1 || $$4more text$$)',
options: {
queryReplacement: '={{ $3This is a test }}',
},
};
const nodeOptions = nodeParameters.options as IDataObject;
await executeQuery.execute.call(
createMockExecuteFunction(nodeParameters),
runQueries,
items,
nodeOptions,
);
expect(runQueries).toHaveBeenCalledWith(
[
{
query: 'INSERT INTO dollar_bug (description) VALUES ($1 || $$4more text$$)',
values: [' $3This is a test '],
options: { partial: true },
},
],
items,
nodeOptions,
);
});
});
describe('Test PostgresV2, insert operation', () => {