admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Forbid raw enums (no-changelog)

Browse Source
This commit is contained in:
Michael Kret
2023-04-21 14:23:15 +03:00
committed by GitHub
parent da31925083
commit 0e93fe064e
39 changed files with 119 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nodes-base/nodes/Todoist/v1/OperationHandler.ts
View File

@@ -42,7 +42,7 @@ export interface Command {
};
}
export enum CommandType {
export const enum CommandType {
ITEM_MOVE = 'item_move',
ITEM_ADD = 'item_add',
ITEM_UPDATE = 'item_update',

21
packages/nodes-base/nodes/Todoist/v1/Service.ts
View File

@@ -35,17 +35,16 @@ export class TodoistService implements Service {
};
}
export enum OperationType {
create = 'create',
close = 'close',
delete = 'delete',
get = 'get',
getAll = 'getAll',
reopen = 'reopen',
update = 'update',
move = 'move',
sync = 'sync',
}
export type OperationType =
| 'create'
| 'close'
| 'delete'
| 'get'
| 'getAll'
| 'reopen'
| 'update'
| 'move'
| 'sync';
export interface Section {
name: string;

11
packages/nodes-base/nodes/Todoist/v1/TodoistV1.node.ts
View File

@@ -13,7 +13,8 @@ import type {
import { todoistApiRequest } from '../GenericFunctions';
import { OperationType, TodoistService } from './Service';
import type { OperationType } from './Service';
import { TodoistService } from './Service';
// interface IBodyCreateTask {
// content?: string;
@@ -702,15 +703,11 @@ export class TodoistV1 implements INodeType {
const service = new TodoistService();
let responseData;
const resource = this.getNodeParameter('resource', 0);
const operation = this.getNodeParameter('operation', 0);
const operation = this.getNodeParameter('operation', 0) as OperationType;
for (let i = 0; i < length; i++) {
try {
if (resource === 'task') {
responseData = await service.execute(
this,
OperationType[operation as keyof typeof OperationType],
i,
);
responseData = await service.execute(this, operation, i);
}
if (Array.isArray(responseData?.data)) {
returnData.push.apply(returnData, responseData?.data as IDataObject[]);

2
packages/nodes-base/nodes/Todoist/v2/OperationHandler.ts
View File

@@ -42,7 +42,7 @@ export interface Command {
};
}
export enum CommandType {
export const enum CommandType {
ITEM_MOVE = 'item_move',
ITEM_ADD = 'item_add',
ITEM_UPDATE = 'item_update',

21
packages/nodes-base/nodes/Todoist/v2/Service.ts
View File

@@ -35,17 +35,16 @@ export class TodoistService implements Service {
};
}
export enum OperationType {
create = 'create',
close = 'close',
delete = 'delete',
get = 'get',
getAll = 'getAll',
reopen = 'reopen',
update = 'update',
move = 'move',
sync = 'sync',
}
export type OperationType =
| 'create'
| 'close'
| 'delete'
| 'get'
| 'getAll'
| 'reopen'
| 'update'
| 'move'
| 'sync';
export interface Section {
name: string;

11
packages/nodes-base/nodes/Todoist/v2/TodoistV2.node.ts
View File

@@ -13,7 +13,8 @@ import type {
import { todoistApiRequest } from '../GenericFunctions';
import { OperationType, TodoistService } from './Service';
import type { OperationType } from './Service';
import { TodoistService } from './Service';
// interface IBodyCreateTask {
// content?: string;
@@ -701,15 +702,11 @@ export class TodoistV2 implements INodeType {
const service = new TodoistService();
let responseData;
const resource = this.getNodeParameter('resource', 0);
const operation = this.getNodeParameter('operation', 0);
const operation = this.getNodeParameter('operation', 0) as OperationType;
for (let i = 0; i < length; i++) {
try {
if (resource === 'task') {
responseData = await service.execute(
this,
OperationType[operation as keyof typeof OperationType],
i,
);
responseData = await service.execute(this, operation, i);
}
if (responseData !== undefined && Array.isArray(responseData?.data)) {