refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions

View File

@@ -1,11 +1,11 @@
import type { OptionsWithUri } from 'request';
import type {
IDataObject,
IExecuteFunctions,
IHookFunctions,
ILoadOptionsFunctions,
JsonObject,
IRequestOptions,
IHttpRequestMethods,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';
@@ -15,7 +15,7 @@ import type { IFilterRules, ISearchConditions } from './FilterInterface';
export async function agileCrmApiRequest(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
method: string,
method: IHttpRequestMethods,
endpoint: string,
body: any = {},
query: IDataObject = {},
@@ -23,7 +23,7 @@ export async function agileCrmApiRequest(
sendAsForm?: boolean,
): Promise<any> {
const credentials = await this.getCredentials('agileCrmApi');
const options: OptionsWithUri = {
const options: IRequestOptions = {
method,
headers: {
Accept: 'application/json',
@@ -56,7 +56,7 @@ export async function agileCrmApiRequest(
export async function agileCrmApiRequestAllItems(
this: IHookFunctions | ILoadOptionsFunctions | IExecuteFunctions,
method: string,
method: IHttpRequestMethods,
resource: string,
body: any = {},
query: IDataObject = {},
@@ -95,7 +95,7 @@ export async function agileCrmApiRequestAllItems(
export async function agileCrmApiRequestUpdate(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
method = 'PUT',
method: IHttpRequestMethods = 'PUT',
endpoint?: string,
body: any = {},
_query: IDataObject = {},
@@ -103,7 +103,7 @@ export async function agileCrmApiRequestUpdate(
): Promise<any> {
const credentials = await this.getCredentials('agileCrmApi');
const baseUri = `https://${credentials.subdomain}.agilecrm.com/dev/`;
const options: OptionsWithUri = {
const options: IRequestOptions = {
method,
headers: {
Accept: 'application/json',