admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-20 11:22:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Browse Source 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nodes-base/nodes/Google/BigQuery/test/v2/node/executeQuery.test.ts
View File

@@ -10,7 +10,7 @@ jest.mock('../../../v2/transport', () => {
const originalModule = jest.requireActual('../../../v2/transport');
return {
...originalModule,
googleApiRequest: jest.fn(async (method: string, resource: string) => {
googleApiRequest: jest.fn(async (method: IHttpRequestMethods, resource: string) => {
if (resource === '/v2/projects/test-project/jobs' && method === 'POST') {
return {
jobReference: {

2
packages/nodes-base/nodes/Google/BigQuery/test/v2/node/insert.autoMapMode.test.ts
View File

@@ -10,7 +10,7 @@ jest.mock('../../../v2/transport', () => {
const originalModule = jest.requireActual('../../../v2/transport');
return {
...originalModule,
googleApiRequest: jest.fn(async (method: string, resource: string) => {
googleApiRequest: jest.fn(async (method: IHttpRequestMethods, resource: string) => {
if (
resource ===
'/v2/projects/test-project/datasets/bigquery_node_dev_test_dataset/tables/num_text' &&

2
packages/nodes-base/nodes/Google/BigQuery/test/v2/node/insert.manualMode.test.ts
View File

@@ -10,7 +10,7 @@ jest.mock('../../../v2/transport', () => {
const originalModule = jest.requireActual('../../../v2/transport');
return {
...originalModule,
googleApiRequest: jest.fn(async (method: string, resource: string) => {
googleApiRequest: jest.fn(async (method: IHttpRequestMethods, resource: string) => {
if (
resource ===
'/v2/projects/test-project/datasets/bigquery_node_dev_test_dataset/tables/test_json' &&

10
packages/nodes-base/nodes/Google/BigQuery/v1/GenericFunctions.ts
View File

@@ -1,17 +1,17 @@
import type { OptionsWithUri } from 'request';
import type {
IExecuteFunctions,
ILoadOptionsFunctions,
IDataObject,
JsonObject,
IHttpRequestMethods,
IRequestOptions,
} from 'n8n-workflow';
import { NodeApiError, NodeOperationError } from 'n8n-workflow';
import { getGoogleAccessToken } from '../../GenericFunctions';
export async function googleApiRequest(
this: IExecuteFunctions | ILoadOptionsFunctions,
method: string,
method: IHttpRequestMethods,
resource: string,
body: any = {},
qs: IDataObject = {},
@@ -24,7 +24,7 @@ export async function googleApiRequest(
'serviceAccount',
) as string;
const options: OptionsWithUri = {
const options: IRequestOptions = {
headers: {
'Content-Type': 'application/json',
},
@@ -68,7 +68,7 @@ export async function googleApiRequest(
export async function googleApiRequestAllItems(
this: IExecuteFunctions | ILoadOptionsFunctions,
propertyName: string,
method: string,
method: IHttpRequestMethods,
endpoint: string,
body: any = {},

10
packages/nodes-base/nodes/Google/BigQuery/v2/transport/index.ts
View File

@@ -1,9 +1,9 @@
import type { OptionsWithUri } from 'request';
import type {
IDataObject,
IExecuteFunctions,
IHttpRequestMethods,
ILoadOptionsFunctions,
IRequestOptions,
JsonObject,
} from 'n8n-workflow';
import { NodeApiError, NodeOperationError } from 'n8n-workflow';
@@ -11,7 +11,7 @@ import { getGoogleAccessToken } from '../../../GenericFunctions';
export async function googleApiRequest(
this: IExecuteFunctions | ILoadOptionsFunctions,
method: string,
method: IHttpRequestMethods,
resource: string,
body: IDataObject = {},
qs: IDataObject = {},
@@ -24,7 +24,7 @@ export async function googleApiRequest(
'serviceAccount',
) as string;
const options: OptionsWithUri = {
const options: IRequestOptions = {
headers: {
'Content-Type': 'application/json',
},
@@ -70,7 +70,7 @@ export async function googleApiRequest(
export async function googleApiRequestAllItems(
this: IExecuteFunctions | ILoadOptionsFunctions,
propertyName: string,
method: string,
method: IHttpRequestMethods,
endpoint: string,
body: IDataObject = {},
query: IDataObject = {},