refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions

View File

@@ -1,9 +1,9 @@
import type { OptionsWithUrl } from 'request';
import type {
IExecuteFunctions,
ILoadOptionsFunctions,
IDataObject,
IExecuteFunctions,
IHttpRequestMethods,
ILoadOptionsFunctions,
IRequestOptions,
JsonObject,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';
@@ -11,7 +11,7 @@ import { NodeApiError } from 'n8n-workflow';
export async function googleApiRequest(
this: IExecuteFunctions | ILoadOptionsFunctions,
projectId: string,
method: string,
method: IHttpRequestMethods,
resource: string,
body: any = {},
@@ -23,7 +23,7 @@ export async function googleApiRequest(
'googleFirebaseRealtimeDatabaseOAuth2Api',
)) as IDataObject;
const options: OptionsWithUrl = {
const options: IRequestOptions = {
headers: {
'Content-Type': 'application/json',
},
@@ -55,7 +55,7 @@ export async function googleApiRequest(
export async function googleApiRequestAllItems(
this: IExecuteFunctions | ILoadOptionsFunctions,
projectId: string,
method: string,
method: IHttpRequestMethods,
resource: string,
body: any = {},

View File

@@ -7,6 +7,7 @@ import type {
INodeType,
INodeTypeDescription,
JsonObject,
IHttpRequestMethods,
} from 'n8n-workflow';
import { NodeApiError, NodeOperationError } from 'n8n-workflow';
@@ -180,7 +181,7 @@ export class GoogleFirebaseRealtimeDatabase implements INodeType {
try {
const projectId = this.getNodeParameter('projectId', i) as string;
let method = 'GET',
let method: IHttpRequestMethods = 'GET',
attributes = '';
const document: IDataObject = {};
if (operation === 'create') {