refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions

View File

@@ -4,22 +4,22 @@ import type {
IDataObject,
ILoadOptionsFunctions,
JsonObject,
IHttpRequestMethods,
IRequestOptions,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';
import type { OptionsWithUri } from 'request';
/**
* Make an API request to HackerNews
*
*/
export async function hackerNewsApiRequest(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
method: string,
method: IHttpRequestMethods,
endpoint: string,
qs: IDataObject,
): Promise<any> {
const options: OptionsWithUri = {
const options: IRequestOptions = {
method,
qs,
uri: `http://hn.algolia.com/api/v1/${endpoint}`,
@@ -41,7 +41,7 @@ export async function hackerNewsApiRequest(
*/
export async function hackerNewsApiRequestAllItems(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
method: string,
method: IHttpRequestMethods,
endpoint: string,
qs: IDataObject,
): Promise<any> {