refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions

View File

@@ -1,6 +1,11 @@
import type { OptionsWithUri } from 'request';
import type { IExecuteFunctions, IHookFunctions, IDataObject, JsonObject } from 'n8n-workflow';
import type {
IExecuteFunctions,
IHookFunctions,
IDataObject,
JsonObject,
IHttpRequestMethods,
IRequestOptions,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';
/**
@@ -9,14 +14,14 @@ import { NodeApiError } from 'n8n-workflow';
*/
export async function messageBirdApiRequest(
this: IHookFunctions | IExecuteFunctions,
method: string,
method: IHttpRequestMethods,
resource: string,
body: IDataObject,
query: IDataObject = {},
): Promise<any> {
const credentials = await this.getCredentials('messageBirdApi');
const options: OptionsWithUri = {
const options: IRequestOptions = {
headers: {
Accept: 'application/json',
Authorization: `AccessKey ${credentials.accessKey}`,

View File

@@ -4,6 +4,7 @@ import type {
INodeExecutionData,
INodeType,
INodeTypeDescription,
IHttpRequestMethods,
} from 'n8n-workflow';
import { NodeOperationError } from 'n8n-workflow';
@@ -290,7 +291,7 @@ export class MessageBird implements INodeType {
// For Query string
let qs: IDataObject;
let requestMethod;
let requestMethod: IHttpRequestMethods;
let requestPath;
for (let i = 0; i < items.length; i++) {