refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions

View File

@@ -1,11 +1,16 @@
import type { OptionsWithUri } from 'request';
import type { IExecuteFunctions, IHookFunctions, IDataObject, JsonObject } from 'n8n-workflow';
import type {
IExecuteFunctions,
IHookFunctions,
IDataObject,
JsonObject,
IHttpRequestMethods,
IRequestOptions,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';
export async function nasaApiRequest(
this: IHookFunctions | IExecuteFunctions,
method: string,
method: IHttpRequestMethods,
endpoint: string,
qs: IDataObject,
option: IDataObject = {},
@@ -15,7 +20,7 @@ export async function nasaApiRequest(
qs.api_key = credentials.api_key as string;
const options: OptionsWithUri = {
const options: IRequestOptions = {
method,
qs,
uri: uri || `https://api.nasa.gov${endpoint}`,
@@ -36,7 +41,7 @@ export async function nasaApiRequest(
export async function nasaApiRequestAllItems(
this: IHookFunctions | IExecuteFunctions,
propertyName: string,
method: string,
method: IHttpRequestMethods,
resource: string,
query: IDataObject = {},
): Promise<any> {