refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions

View File

@@ -1,16 +1,16 @@
import type { OptionsWithUri } from 'request';
import type {
IDataObject,
IExecuteFunctions,
IHookFunctions,
IHttpRequestMethods,
ILoadOptionsFunctions,
IRequestOptions,
} from 'n8n-workflow';
export async function sendGridApiRequest(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
endpoint: string,
method: string,
method: IHttpRequestMethods,
body: any = {},
qs: IDataObject = {},
@@ -18,7 +18,7 @@ export async function sendGridApiRequest(
): Promise<any> {
const host = 'api.sendgrid.com/v3';
const options: OptionsWithUri = {
const options: IRequestOptions = {
method,
qs,
body,
@@ -40,7 +40,7 @@ export async function sendGridApiRequest(
export async function sendGridApiRequestAllItems(
this: IExecuteFunctions | ILoadOptionsFunctions,
endpoint: string,
method: string,
method: IHttpRequestMethods,
propertyName: string,
body: any = {},

View File

@@ -1,6 +1,7 @@
import type {
IDataObject,
IExecuteFunctions,
IHttpRequestMethods,
ILoadOptionsFunctions,
INodeExecutionData,
INodePropertyOptions,
@@ -146,7 +147,7 @@ export class SendGrid implements INodeType {
const returnAll = this.getNodeParameter('returnAll', i);
const filters = this.getNodeParameter('filters', i);
let endpoint = '/marketing/contacts';
let method = 'GET';
let method: IHttpRequestMethods = 'GET';
const body: IDataObject = {};
if (filters.query && filters.query !== '') {
endpoint = '/marketing/contacts/search';
@@ -186,7 +187,7 @@ export class SendGrid implements INodeType {
if (operation === 'get') {
const by = this.getNodeParameter('by', 0) as string;
let endpoint;
let method;
let method: IHttpRequestMethods;
const body: IDataObject = {};
for (let i = 0; i < length; i++) {
try {