fix(Summarize Node): Fix spaces in Fields to Split By values converted to underscores (#15020)

packages/nodes-base/nodes/Transform/Summarize/test/unitTests/__snapshots__/splitData.test.ts.snap

@@ -1,5 +1,123 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`Test Summarize Node, aggregateAndSplitData should handle split field values containing spaces when convertKeysToString is not set: split-field-with-spaces-array 1`] = `
+[
+  {
+    "pairedItems": [
+      0,
+      2,
+    ],
+    "returnData": {
+      "Product": "Widget A",
+      "appended_Warehouse": [
+        "WH1",
+        "WH3",
+      ],
+    },
+  },
+  {
+    "pairedItems": [
+      1,
+    ],
+    "returnData": {
+      "Product": "Widget B",
+      "appended_Warehouse": [
+        "WH2",
+      ],
+    },
+  },
+]
+`;
+
+exports[`Test Summarize Node, aggregateAndSplitData should handle split field values containing spaces when convertKeysToString is not set: split-field-with-spaces-result 1`] = `
+{
+  "fieldName": "Product",
+  "splits": Map {
+    "Widget A" => {
+      "pairedItems": [
+        0,
+        2,
+      ],
+      "returnData": {
+        "appended_Warehouse": [
+          "WH1",
+          "WH3",
+        ],
+      },
+    },
+    "Widget B" => {
+      "pairedItems": [
+        1,
+      ],
+      "returnData": {
+        "appended_Warehouse": [
+          "WH2",
+        ],
+      },
+    },
+  },
+}
+`;
+
+exports[`Test Summarize Node, aggregateAndSplitData should handle split field values containing spaces when convertKeysToString is true: split-field-with-spaces-array 1`] = `
+[
+  {
+    "pairedItems": [
+      0,
+      2,
+    ],
+    "returnData": {
+      "Product": "Widget A",
+      "appended_Warehouse": [
+        "WH1",
+        "WH3",
+      ],
+    },
+  },
+  {
+    "pairedItems": [
+      1,
+    ],
+    "returnData": {
+      "Product": "Widget B",
+      "appended_Warehouse": [
+        "WH2",
+      ],
+    },
+  },
+]
+`;
+
+exports[`Test Summarize Node, aggregateAndSplitData should handle split field values containing spaces when convertKeysToString is true: split-field-with-spaces-result 1`] = `
+{
+  "fieldName": "Product",
+  "splits": Map {
+    "Widget A" => {
+      "pairedItems": [
+        0,
+        2,
+      ],
+      "returnData": {
+        "appended_Warehouse": [
+          "WH1",
+          "WH3",
+        ],
+      },
+    },
+    "Widget B" => {
+      "pairedItems": [
+        1,
+      ],
+      "returnData": {
+        "appended_Warehouse": [
+          "WH2",
+        ],
+      },
+    },
+  },
+}
+`;
+
 exports[`Test Summarize Node, aggregateAndSplitData should not convert numbers to strings: array 1`] = `
 [
   {

packages/nodes-base/nodes/Transform/Summarize/test/unitTests/splitData.test.ts

@@ -88,6 +88,95 @@ describe('Test Summarize Node, aggregateAndSplitData', () => {
 		expect(flattenAggregationResultToArray(result)).toMatchSnapshot('array');
 	});
 
+	test('should handle split field values containing spaces when convertKeysToString is not set', () => {
+		const data = [
+			{
+				Product: 'Widget A',
+				Warehouse: 'WH1',
+				Qty: '5',
+				_itemIndex: 0,
+			},
+			{
+				Product: 'Widget B',
+				Warehouse: 'WH2',
+				Qty: '3',
+				_itemIndex: 1,
+			},
+			{
+				Product: 'Widget A',
+				Warehouse: 'WH3',
+				Qty: '2',
+				_itemIndex: 2,
+			},
+		];
+
+		const aggregations: Aggregations = [
+			{
+				aggregation: 'append',
+				field: 'Warehouse',
+				includeEmpty: true,
+			},
+		];
+
+		const result = aggregateAndSplitData({
+			splitKeys: ['Product'],
+			inputItems: data,
+			fieldsToSummarize: aggregations,
+			options: { continueIfFieldNotFound: true },
+			getValue: fieldValueGetter(),
+		});
+
+		expect(result).toMatchSnapshot('split-field-with-spaces-result');
+		expect(flattenAggregationResultToArray(result)).toMatchSnapshot(
+			'split-field-with-spaces-array',
+		);
+	});
+
+	test('should handle split field values containing spaces when convertKeysToString is true', () => {
+		const data = [
+			{
+				Product: 'Widget A',
+				Warehouse: 'WH1',
+				Qty: '5',
+				_itemIndex: 0,
+			},
+			{
+				Product: 'Widget B',
+				Warehouse: 'WH2',
+				Qty: '3',
+				_itemIndex: 1,
+			},
+			{
+				Product: 'Widget A',
+				Warehouse: 'WH3',
+				Qty: '2',
+				_itemIndex: 2,
+			},
+		];
+
+		const aggregations: Aggregations = [
+			{
+				aggregation: 'append',
+				field: 'Warehouse',
+				includeEmpty: true,
+			},
+		];
+
+		const result = aggregateAndSplitData({
+			splitKeys: ['Product'],
+			inputItems: data,
+			fieldsToSummarize: aggregations,
+			options: { continueIfFieldNotFound: true },
+			getValue: fieldValueGetter(),
+			convertKeysToString: true,
+		});
+
+		expect(result).toMatchSnapshot('split-field-with-spaces-result');
+		expect(flattenAggregationResultToArray(result)).toMatchSnapshot(
+			'split-field-with-spaces-array',
+		);
+	});
+
 	describe('with skipEmptySplitFields=true', () => {
 		test('should skip empty split fields', () => {
 			const data = [

packages/nodes-base/nodes/Transform/Summarize/utils.ts

@@ -225,22 +225,22 @@ export function aggregateAndSplitData({
 
 	const groupedItems = new Map<unknown, IDataObject[]>();
 	for (const item of inputItems) {
-		let key = getValue(item, firstSplitKey);
+		let splitValue = getValue(item, firstSplitKey);
 
-		if (key && typeof key === 'object') {
+		if (splitValue && typeof splitValue === 'object') {
-			key = JSON.stringify(key);
+			splitValue = JSON.stringify(splitValue);
 		}
 
 		if (convertKeysToString) {
-			key = normalizeFieldName(String(key));
+			splitValue = String(splitValue);
 		}
 
-		if (options.skipEmptySplitFields && typeof key !== 'number' && !key) {
+		if (options.skipEmptySplitFields && typeof splitValue !== 'number' && !splitValue) {
 			continue;
 		}
 
-		const group = groupedItems.get(key) ?? [];
+		const group = groupedItems.get(splitValue) ?? [];
-		groupedItems.set(key, group.concat([item]));
+		groupedItems.set(splitValue, group.concat([item]));
 	}
 
 	const splits = new Map(