admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

✨ Copy data on execution only if needed

Browse Source
This commit is contained in:
Jan Oberhauser
2019-08-01 22:55:33 +02:00
parent a8f1f9c0ba
commit 1b59d7b886
20 changed files with 182 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/nodes-base/nodes/ReadBinaryFile.node.ts
View File

@@ -55,10 +55,6 @@ export class ReadBinaryFile implements INodeType {
const dataPropertyName = this.getNodeParameter('dataPropertyName') as string;
const filePath = this.getNodeParameter('filePath') as string;
if (item.binary === undefined) {
item.binary = {};
}
let data;
try {
data = await fsReadFileAsync(filePath) as Buffer;
@@ -69,9 +65,22 @@ export class ReadBinaryFile implements INodeType {
throw error;
}
item.binary[dataPropertyName] = await this.helpers.prepareBinaryData(data, filePath);
return item;
const newItem: INodeExecutionData = {
json: item.json,
binary: {},
};
if (item.binary !== undefined) {
// Create a shallow copy of the binary data so that the old
// data references which do not get changed still stay behind
// but the incoming data does not get changed.
Object.assign(newItem.binary, item.binary);
}
newItem.binary![dataPropertyName] = await this.helpers.prepareBinaryData(data, filePath);
return newItem;
}
}