admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

✨ Improve node error handling (#1309)

Browse Source 
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

* ⚡ change return type of callback

* ⚡ add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

* ⚡ change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

* ✨ add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

* ⚡ add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

* ⚡ add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

* ✨ Replace current errors with custom errors (#1576)

* ⚡ Introduce NodeApiError in catch blocks

* ⚡ Introduce NodeOperationError in nodes

* ⚡ Add missing errors and remove incompatible

* ⚡ Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

* ✨ Add XML parsing to NodeApiError

* ⚡ Simplify error handling in Rekognition node

* ⚡ Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

* ⚡ Find property in parsed XML

* ⚡ Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

* ⚡ Add custom errors to latest contributions

* 👕 Fix linting issues

* ⚡ Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

* ⚡ Apply feedback to A nodes

* ⚡ Apply feedback to missed A node

* ⚡ Apply feedback to B-D nodes

* ⚡ Apply feedback to E-F nodes

* ⚡ Apply feedback to G nodes

* ⚡ Apply feedback to H-L nodes

* ⚡ Apply feedback to M nodes

* ⚡ Apply feedback to P nodes

* ⚡ Apply feedback to R nodes

* ⚡ Apply feedback to S nodes

* ⚡ Apply feedback to T nodes

* ⚡ Apply feedback to V-Z nodes

* ⚡ Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

* ⚡ Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2021-04-16 18:33:36 +02:00
committed by GitHub
parent 1a0e129921
commit 1d27a9e87e
374 changed files with 2041 additions and 2826 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
packages/nodes-base/nodes/Salesforce/Salesforce.node.ts
View File

@@ -9,6 +9,8 @@ import {
INodePropertyOptions,
INodeType,
INodeTypeDescription,
NodeApiError,
NodeOperationError,
} from 'n8n-workflow';
import {
@@ -950,7 +952,7 @@ export class Salesforce implements INodeType {
const updateFields = this.getNodeParameter('updateFields', i) as IDataObject;
const body: ILead = {};
if (!Object.keys(updateFields).length) {
throw new Error('You must add at least one update field');
throw new NodeOperationError(this.getNode(), 'You must add at least one update field');
}
if (updateFields.lastname !== undefined) {
body.LastName = updateFields.lastname as string;
@@ -1053,8 +1055,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Lead', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Lead/delete-lead-id
@@ -1062,8 +1064,8 @@ export class Salesforce implements INodeType {
const leadId = this.getNodeParameter('leadId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/lead/${leadId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Lead/get-lead
@@ -1220,7 +1222,7 @@ export class Salesforce implements INodeType {
const updateFields = this.getNodeParameter('updateFields', i) as IDataObject;
const body: IContact = {};
if (!Object.keys(updateFields).length) {
throw new Error('You must add at least one update field');
throw new NodeOperationError(this.getNode(), 'You must add at least one update field');
}
if (updateFields.fax !== undefined) {
body.Fax = updateFields.fax as string;
@@ -1341,8 +1343,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Contact', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Contact/delete-contact-id
@@ -1350,8 +1352,8 @@ export class Salesforce implements INodeType {
const contactId = this.getNodeParameter('contactId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/contact/${contactId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Contact/get-contact
@@ -1443,8 +1445,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, customObject, returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
if (operation === 'delete') {
@@ -1452,8 +1454,8 @@ export class Salesforce implements INodeType {
const recordId = this.getNodeParameter('recordId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/${customObject}/${recordId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
}
@@ -1589,8 +1591,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Opportunity', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Opportunity/delete-opportunity-id
@@ -1598,8 +1600,8 @@ export class Salesforce implements INodeType {
const opportunityId = this.getNodeParameter('opportunityId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/opportunity/${opportunityId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Opportunity/get-opportunity
@@ -1827,8 +1829,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Account', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Account/delete-account-id
@@ -1836,8 +1838,8 @@ export class Salesforce implements INodeType {
const accountId = this.getNodeParameter('accountId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/account/${accountId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Account/get-account
@@ -1987,8 +1989,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Case', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Case/delete-case-id
@@ -1996,8 +1998,8 @@ export class Salesforce implements INodeType {
const caseId = this.getNodeParameter('caseId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/case/${caseId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Case/get-case
@@ -2214,8 +2216,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Task', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Task/delete-task-id
@@ -2223,8 +2225,8 @@ export class Salesforce implements INodeType {
const taskId = this.getNodeParameter('taskId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/task/${taskId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Task/get-task
@@ -2247,7 +2249,7 @@ export class Salesforce implements INodeType {
body.Body = items[i].binary![binaryPropertyName].data;
body.ContentType = items[i].binary![binaryPropertyName].mimeType;
} else {
throw new Error(`The property ${binaryPropertyName} does not exist`);
throw new NodeOperationError(this.getNode(), `The property ${binaryPropertyName} does not exist`);
}
if (additionalFields.description !== undefined) {
body.Description = additionalFields.description as string;
@@ -2271,7 +2273,7 @@ export class Salesforce implements INodeType {
body.Body = items[i].binary![binaryPropertyName].data;
body.ContentType = items[i].binary![binaryPropertyName].mimeType;
} else {
throw new Error(`The property ${binaryPropertyName} does not exist`);
throw new NodeOperationError(this.getNode(), `The property ${binaryPropertyName} does not exist`);
}
}
if (updateFields.name !== undefined) {
@@ -2306,8 +2308,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'Attachment', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Attachment/delete-attachment-id
@@ -2315,8 +2317,8 @@ export class Salesforce implements INodeType {
const attachmentId = this.getNodeParameter('attachmentId', i) as string;
try {
responseData = await salesforceApiRequest.call(this, 'DELETE', `/sobjects/attachment/${attachmentId}`);
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
//https://developer.salesforce.com/docs/api-explorer/sobject/Attachment/get-attachment-id
@@ -2343,8 +2345,8 @@ export class Salesforce implements INodeType {
qs.q = getQuery(options, 'User', returnAll, limit) as string;
responseData = await salesforceApiRequestAllItems.call(this, 'records', 'GET', '/query', {}, qs);
}
} catch (err) {
throw new Error(`Salesforce Error: ${err}`);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
}
}