mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 10:02:05 +00:00
refactor: Unify severity and level for all application errors for Sentry (no-changelog) (#7956)
## Summary Unify `severity` and `level` for all backend application errors for Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7914#issuecomment-1840433542 ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
This commit is contained in:
@@ -1528,7 +1528,7 @@ export async function httpRequestWithAuthentication(
|
||||
throw new NodeOperationError(
|
||||
node,
|
||||
`Node "${node.name}" does not have any credentials of type "${credentialsType}" set!`,
|
||||
{ severity: 'warning' },
|
||||
{ level: 'warning' },
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1722,7 +1722,7 @@ export async function requestWithAuthentication(
|
||||
throw new NodeOperationError(
|
||||
node,
|
||||
`Node "${node.name}" does not have any credentials of type "${credentialsType}" set!`,
|
||||
{ severity: 'warning' },
|
||||
{ level: 'warning' },
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1881,7 +1881,7 @@ export async function getCredentials(
|
||||
throw new NodeOperationError(
|
||||
node,
|
||||
`Node type "${node.type}" does not have any credentials defined!`,
|
||||
{ severity: 'warning' },
|
||||
{ level: 'warning' },
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1892,7 +1892,7 @@ export async function getCredentials(
|
||||
throw new NodeOperationError(
|
||||
node,
|
||||
`Node type "${node.type}" does not have any credentials of type "${type}" defined!`,
|
||||
{ severity: 'warning' },
|
||||
{ level: 'warning' },
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1917,14 +1917,14 @@ export async function getCredentials(
|
||||
// Credentials are required so error
|
||||
if (!node.credentials) {
|
||||
throw new NodeOperationError(node, 'Node does not have any credentials set!', {
|
||||
severity: 'warning',
|
||||
level: 'warning',
|
||||
});
|
||||
}
|
||||
if (!node.credentials[type]) {
|
||||
throw new NodeOperationError(
|
||||
node,
|
||||
`Node does not have any credentials set for "${type}"!`,
|
||||
{ severity: 'warning' },
|
||||
{ level: 'warning' },
|
||||
);
|
||||
}
|
||||
} else {
|
||||
@@ -2903,7 +2903,7 @@ const getFileSystemHelperFunctions = (node: INode): FileSystemHelperFunctions =>
|
||||
throw error.code === 'ENOENT'
|
||||
? new NodeOperationError(node, error, {
|
||||
message: `The file "${String(filePath)}" could not be accessed.`,
|
||||
severity: 'warning',
|
||||
level: 'warning',
|
||||
})
|
||||
: error;
|
||||
}
|
||||
@@ -2911,7 +2911,7 @@ const getFileSystemHelperFunctions = (node: INode): FileSystemHelperFunctions =>
|
||||
const allowedPaths = getAllowedPaths();
|
||||
const message = allowedPaths.length ? ` Allowed paths: ${allowedPaths.join(', ')}` : '';
|
||||
throw new NodeOperationError(node, `Access to the file is not allowed.${message}`, {
|
||||
severity: 'warning',
|
||||
level: 'warning',
|
||||
});
|
||||
}
|
||||
return createReadStream(filePath);
|
||||
@@ -2924,7 +2924,7 @@ const getFileSystemHelperFunctions = (node: INode): FileSystemHelperFunctions =>
|
||||
async writeContentToFile(filePath, content, flag) {
|
||||
if (isFilePathBlocked(filePath as string)) {
|
||||
throw new NodeOperationError(node, `The file "${String(filePath)}" is not writable.`, {
|
||||
severity: 'warning',
|
||||
level: 'warning',
|
||||
});
|
||||
}
|
||||
return fsWriteFile(filePath, content, { encoding: 'binary', flag });
|
||||
|
||||
Reference in New Issue
Block a user