admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Remove usless catch blocks, and add a linting rule to prevent them (no-changelog) (#12730)

Browse Source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2025-01-20 18:20:04 +01:00
committed by GitHub
parent 4ee4552b0e
commit 202da76380
17 changed files with 220 additions and 242 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
packages/nodes-base/nodes/Disqus/Disqus.node.ts
View File

@@ -601,16 +601,12 @@ export class Disqus implements INodeType {
Object.assign(qs, additionalFields);
try {
const responseData = await disqusApiRequest.call(this, requestMethod, qs, endpoint);
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject[]),
{ itemData: { item: i } },
);
returnData.push(...executionData);
} catch (error) {
throw error;
}
const responseData = await disqusApiRequest.call(this, requestMethod, qs, endpoint);
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject[]),
{ itemData: { item: i } },
);
returnData.push(...executionData);
} else if (operation === 'getPosts') {
// ----------------------------------
// getPosts
@@ -629,28 +625,24 @@ export class Disqus implements INodeType {
qs.forum = id;
qs.limit = 100;
try {
let responseData: IDataObject = {};
if (returnAll) {
responseData.response = await disqusApiRequestAllItems.call(
this,
requestMethod,
qs,
endpoint,
);
} else {
const limit = this.getNodeParameter('limit', i);
qs.limit = limit;
responseData = await disqusApiRequest.call(this, requestMethod, qs, endpoint);
}
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject),
{ itemData: { item: i } },
let responseData: IDataObject = {};
if (returnAll) {
responseData.response = await disqusApiRequestAllItems.call(
this,
requestMethod,
qs,
endpoint,
);
returnData.push(...executionData);
} catch (error) {
throw error;
} else {
const limit = this.getNodeParameter('limit', i);
qs.limit = limit;
responseData = await disqusApiRequest.call(this, requestMethod, qs, endpoint);
}
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject),
{ itemData: { item: i } },
);
returnData.push(...executionData);
} else if (operation === 'getCategories') {
// ----------------------------------
// getCategories
@@ -668,34 +660,30 @@ export class Disqus implements INodeType {
qs.forum = id;
qs.limit = 100;
try {
let responseData: IDataObject = {};
let responseData: IDataObject = {};
if (returnAll) {
responseData.response = await disqusApiRequestAllItems.call(
this,
requestMethod,
qs,
endpoint,
);
} else {
const limit = this.getNodeParameter('limit', i);
qs.limit = limit;
responseData = (await disqusApiRequest.call(
this,
requestMethod,
qs,
endpoint,
)) as IDataObject;
}
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject),
{ itemData: { item: i } },
if (returnAll) {
responseData.response = await disqusApiRequestAllItems.call(
this,
requestMethod,
qs,
endpoint,
);
returnData.push(...executionData);
} catch (error) {
throw error;
} else {
const limit = this.getNodeParameter('limit', i);
qs.limit = limit;
responseData = (await disqusApiRequest.call(
this,
requestMethod,
qs,
endpoint,
)) as IDataObject;
}
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject),
{ itemData: { item: i } },
);
returnData.push(...executionData);
} else if (operation === 'getThreads') {
// ----------------------------------
// getThreads
@@ -715,28 +703,24 @@ export class Disqus implements INodeType {
Object.assign(qs, additionalFields);
try {
let responseData: IDataObject = {};
if (returnAll) {
responseData.response = await disqusApiRequestAllItems.call(
this,
requestMethod,
qs,
endpoint,
);
} else {
const limit = this.getNodeParameter('limit', i);
qs.limit = limit;
responseData = await disqusApiRequest.call(this, requestMethod, qs, endpoint);
}
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject),
{ itemData: { item: i } },
let responseData: IDataObject = {};
if (returnAll) {
responseData.response = await disqusApiRequestAllItems.call(
this,
requestMethod,
qs,
endpoint,
);
returnData.push(...executionData);
} catch (error) {
throw error;
} else {
const limit = this.getNodeParameter('limit', i);
qs.limit = limit;
responseData = await disqusApiRequest.call(this, requestMethod, qs, endpoint);
}
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData.response as IDataObject),
{ itemData: { item: i } },
);
returnData.push(...executionData);
} else {
throw new NodeOperationError(
this.getNode(),

16
packages/nodes-base/nodes/Disqus/GenericFunctions.ts
View File

@@ -66,14 +66,10 @@ export async function disqusApiRequestAllItems(
let responseData;
try {
do {
responseData = await disqusApiRequest.call(this, method, qs, uri, body, option);
qs.cursor = responseData.cursor.id;
returnData.push.apply(returnData, responseData.response as IDataObject[]);
} while (responseData.cursor.more === true && responseData.cursor.hasNext === true);
return returnData;
} catch (error) {
throw error;
}
do {
responseData = await disqusApiRequest.call(this, method, qs, uri, body, option);
qs.cursor = responseData.cursor.id;
returnData.push.apply(returnData, responseData.response as IDataObject[]);
} while (responseData.cursor.more === true && responseData.cursor.hasNext === true);
return returnData;
}