From 224842c790fd0f976d8d50adef871ef2e5c4fe83 Mon Sep 17 00:00:00 2001
From: Jan Oberhauser <jan.oberhauser@gmail.com>
Date: Wed, 8 Jul 2020 09:40:47 +0200
Subject: [PATCH] :zap: Get rid of mmmagic for mime-type detection

---
 packages/core/package.json                |  5 +--
 packages/core/src/NodeExecuteFunctions.ts | 39 +++++++++++++----------
 2 files changed, 25 insertions(+), 19 deletions(-)

diff --git a/packages/core/package.json b/packages/core/package.json
index 7a4b0c7349..ac55db99c9 100644
--- a/packages/core/package.json
+++ b/packages/core/package.json
@@ -30,7 +30,7 @@
         "@types/express": "^4.16.1",
         "@types/jest": "^24.0.18",
         "@types/lodash.get": "^4.4.6",
-        "@types/mmmagic": "^0.4.29",
+        "@types/mime-types": "^2.1.0",
         "@types/node": "^10.10.1",
         "@types/request-promise-native": "^1.0.15",
         "jest": "^24.9.0",
@@ -43,8 +43,9 @@
         "client-oauth2": "^4.2.5",
         "cron": "^1.7.2",
         "crypto-js": "3.1.9-1",
+        "file-type": "^14.6.2",
         "lodash.get": "^4.4.2",
-        "mmmagic": "^0.5.2",
+        "mime-types": "^2.1.27",
         "n8n-workflow": "~0.33.0",
         "p-cancelable": "^2.0.0",
         "request": "^2.88.2",
diff --git a/packages/core/src/NodeExecuteFunctions.ts b/packages/core/src/NodeExecuteFunctions.ts
index d500d56f88..5efbe32914 100644
--- a/packages/core/src/NodeExecuteFunctions.ts
+++ b/packages/core/src/NodeExecuteFunctions.ts
@@ -44,14 +44,9 @@ import * as express from 'express';
 import * as path from 'path';
 import { OptionsWithUrl, OptionsWithUri } from 'request';
 import * as requestPromise from 'request-promise-native';
-
-import { Magic, MAGIC_MIME_TYPE } from 'mmmagic';
-
 import { createHmac } from 'crypto';
-
-
-const magic = new Magic(MAGIC_MIME_TYPE);
-
+import { fromBuffer } from 'file-type';
+import { lookup } from 'mime-types';
 
 
 /**
@@ -66,18 +61,28 @@ const magic = new Magic(MAGIC_MIME_TYPE);
  */
 export async function prepareBinaryData(binaryData: Buffer, filePath?: string, mimeType?: string): Promise<IBinaryData> {
 	if (!mimeType) {
-		// If not mime type is given figure it out
-		mimeType = await new Promise<string>(
-			(resolve, reject) => {
-				magic.detect(binaryData, (err: Error, mimeType: string) => {
-					if (err) {
-						return reject(err);
-					}
+		// If no mime type is given figure it out
 
-					return resolve(mimeType);
-				});
+		if (filePath) {
+			// Use file path to guess mime type
+			const mimeTypeLookup = lookup(filePath);
+			if (mimeTypeLookup) {
+				mimeType = mimeTypeLookup;
 			}
-		);
+		}
+
+		if (!mimeType) {
+			// Use buffer to guess mime type
+			const fileTypeData = await fromBuffer(binaryData);
+			if (fileTypeData) {
+				mimeType = fileTypeData.mime;
+			}
+		}
+
+		if (!mimeType) {
+			// Fall back to text
+			mimeType = 'text/plain';
+		}
 	}
 
 	const returnData: IBinaryData = {