admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(n8n Evaluation Node): Make string similarity be inverted (no-changelog) (#17239)

Browse Source
This commit is contained in:
jeanpaul
2025-07-11 15:57:22 +02:00
committed by GitHub
parent f928c58042
commit 25139b2c77
2 changed files with 39 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
packages/nodes-base/nodes/Evaluation/test/metricHandlers.test.ts
View File

@@ -478,7 +478,7 @@ describe('metricHandlers', () => {
});
describe('stringSimilarity', () => {
it('should return Levenshtein distance', async () => {
it('should return inverted similarity score', async () => {
mockExecuteFunctions.getNodeParameter.mockImplementation((paramName: string) => {
if (paramName === 'expectedAnswer') return 'hello';
if (paramName === 'actualAnswer') return 'helo';
@@ -488,10 +488,11 @@ describe('metricHandlers', () => {
const result = await metricHandlers.stringSimilarity.call(mockExecuteFunctions, 0);
expect(result).toEqual({ 'String similarity': 1 });
// Edit distance is 1, longer string length is 5, so similarity = 1 - (1/5) = 0.8
expect(result).toEqual({ 'String similarity': 0.8 });
});
it('should return 0 for identical strings', async () => {
it('should return 1 for identical strings', async () => {
mockExecuteFunctions.getNodeParameter.mockImplementation((paramName: string) => {
if (paramName === 'expectedAnswer') return 'hello';
if (paramName === 'actualAnswer') return 'hello';
@@ -501,7 +502,7 @@ describe('metricHandlers', () => {
const result = await metricHandlers.stringSimilarity.call(mockExecuteFunctions, 0);
expect(result).toEqual({ 'String similarity': 0 });
expect(result).toEqual({ 'String similarity': 1 });
});
it('should handle whitespace trimming', async () => {
@@ -514,7 +515,35 @@ describe('metricHandlers', () => {
const result = await metricHandlers.stringSimilarity.call(mockExecuteFunctions, 0);
expect(result).toEqual({ 'String similarity': 0 });
expect(result).toEqual({ 'String similarity': 1 });
});
it('should return low similarity for very different strings', async () => {
mockExecuteFunctions.getNodeParameter.mockImplementation((paramName: string) => {
if (paramName === 'expectedAnswer') return 'hello';
if (paramName === 'actualAnswer') return 'world';
if (paramName === 'options.metricName') return 'String similarity';
return undefined;
});
const result = await metricHandlers.stringSimilarity.call(mockExecuteFunctions, 0);
// Edit distance is 4, longer string length is 5, so similarity = 1 - (4/5) = 0.2
expect(result['String similarity']).toBeCloseTo(0.2, 2);
});
it('should handle different string lengths', async () => {
mockExecuteFunctions.getNodeParameter.mockImplementation((paramName: string) => {
if (paramName === 'expectedAnswer') return 'hello';
if (paramName === 'actualAnswer') return 'hello world';
if (paramName === 'options.metricName') return 'String similarity';
return undefined;
});
const result = await metricHandlers.stringSimilarity.call(mockExecuteFunctions, 0);
// Edit distance is 6, longer string length is 11, so similarity = 1 - (6/11) ≈ 0.45
expect(result['String similarity']).toBeCloseTo(0.45, 2);
});
it('should throw error for missing expected answer', async () => {

6
packages/nodes-base/nodes/Evaluation/utils/metricHandlers.ts
View File

@@ -166,8 +166,12 @@ export const metricHandlers = {
'String similarity',
) as string;
const editDistance = distance(expectedAnswer, actualAnswer);
const longerStringLength = Math.max(expectedAnswer.length, actualAnswer.length);
const similarity = longerStringLength === 0 ? 1 : 1 - editDistance / longerStringLength;
return {
[metricName]: distance(expectedAnswer, actualAnswer),
[metricName]: similarity,
};
},