From 283d1ca583247567b02dea8bc76eb68aec377db4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Thu, 20 Jun 2024 11:02:30 +0200 Subject: [PATCH] refactor(core): Rename usage metrics method per suggestion (no-changelog) (#9810) --- packages/cli/src/License.ts | 2 +- packages/cli/src/services/usageMetrics.service.ts | 2 +- packages/cli/test/integration/usage-metrics.service.test.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/cli/src/License.ts b/packages/cli/src/License.ts index 6dfd542534..ab61e257ec 100644 --- a/packages/cli/src/License.ts +++ b/packages/cli/src/License.ts @@ -85,7 +85,7 @@ export class License { ? async () => await this.usageMetricsService.collectUsageMetrics() : async () => []; const collectPassthroughData = isMainInstance - ? async () => await this.usageMetricsService.getActiveWorkflowIds() + ? async () => await this.usageMetricsService.collectPassthroughData() : async () => ({}); const renewalEnabled = this.renewalEnabled(instanceType); diff --git a/packages/cli/src/services/usageMetrics.service.ts b/packages/cli/src/services/usageMetrics.service.ts index f9d925d090..5f8578e8d4 100644 --- a/packages/cli/src/services/usageMetrics.service.ts +++ b/packages/cli/src/services/usageMetrics.service.ts @@ -31,7 +31,7 @@ export class UsageMetricsService { ]; } - async getActiveWorkflowIds() { + async collectPassthroughData() { return { activeWorkflowIds: await this.workflowRepository.getActiveIds(), }; diff --git a/packages/cli/test/integration/usage-metrics.service.test.ts b/packages/cli/test/integration/usage-metrics.service.test.ts index a620f16376..515022830f 100644 --- a/packages/cli/test/integration/usage-metrics.service.test.ts +++ b/packages/cli/test/integration/usage-metrics.service.test.ts @@ -10,8 +10,8 @@ describe('UsageMetricsService', () => { workflowRepository, ); - describe('getActiveWorkflowIds', () => { - test('should return active workflow IDs', async () => { + describe('collectPassthroughData', () => { + test('should return an object with active workflow IDs', async () => { /** * Arrange */ @@ -21,7 +21,7 @@ describe('UsageMetricsService', () => { /** * Act */ - const result = await usageMetricsService.getActiveWorkflowIds(); + const result = await usageMetricsService.collectPassthroughData(); /** * Assert