From 2a5c1e2152d387f396947a0b815d7164d079e819 Mon Sep 17 00:00:00 2001 From: Jaakko Husso Date: Wed, 6 Aug 2025 15:08:32 +0300 Subject: [PATCH] chore(editor): Drop rag starter callout experiment flag (no-changelog) (#18039) --- cypress/e2e/4-node-creator.cy.ts | 4 +++ cypress/e2e/52-rag-callout-experiment.cy.ts | 28 ++-------------- .../src/components/ParameterInputList.vue | 8 ++--- .../src/composables/useCalloutHelpers.test.ts | 33 ++++--------------- .../src/composables/useCalloutHelpers.ts | 16 ++------- packages/frontend/editor-ui/src/constants.ts | 7 ---- 6 files changed, 20 insertions(+), 76 deletions(-) diff --git a/cypress/e2e/4-node-creator.cy.ts b/cypress/e2e/4-node-creator.cy.ts index f7993d5e64..80a34b5cf7 100644 --- a/cypress/e2e/4-node-creator.cy.ts +++ b/cypress/e2e/4-node-creator.cy.ts @@ -535,6 +535,10 @@ describe('Node Creator', () => { // Loop over all vector stores and check if they have the three actions vectorStores.each((_i, vectorStore) => { + if (vectorStore.includes('RAG starter template')) { + return; + } + nodeCreatorFeature.getters.getCreatorItem(vectorStore).click(); actions.forEach((action) => { nodeCreatorFeature.getters.getCreatorItem(action).should('be.visible').realHover(); diff --git a/cypress/e2e/52-rag-callout-experiment.cy.ts b/cypress/e2e/52-rag-callout-experiment.cy.ts index ef3c58bd6d..7b51817fa7 100644 --- a/cypress/e2e/52-rag-callout-experiment.cy.ts +++ b/cypress/e2e/52-rag-callout-experiment.cy.ts @@ -1,22 +1,10 @@ -import { overrideFeatureFlag } from '../composables/featureFlags'; import { openNodeCreator, searchBar } from '../composables/nodeCreator'; import { addNodeToCanvas, navigateToNewWorkflowPage } from '../composables/workflow'; describe('RAG callout experiment', () => { describe('NDV callout', () => { - it('should not show callout if experiment is control', () => { - overrideFeatureFlag('033_rag_template', 'control'); - - navigateToNewWorkflowPage(); - - addNodeToCanvas('Zep Vector Store', true, true, 'Add documents to vector store'); - - cy.contains('Tip: Get a feel for vector stores in n8n with our').should('not.exist'); - }); - - it('should callout is variant and open on click', () => { + it('should show callout and open template on click', () => { cy.intercept('workflows/templates/rag-starter-template?fromJson=true'); - overrideFeatureFlag('033_rag_template', 'variant'); navigateToNewWorkflowPage(); @@ -37,20 +25,8 @@ describe('RAG callout experiment', () => { }); }); describe('search callout', () => { - it('should not show callout if experiment is control', () => { - overrideFeatureFlag('033_rag_template', 'control'); - - navigateToNewWorkflowPage(); - - openNodeCreator(); - searchBar().type('rag'); - - cy.contains('RAG starter template').should('not.exist'); - }); - - it('should should callout is variant and open on click', () => { + it('should show callout and open template on click', () => { cy.intercept('workflows/templates/rag-starter-template?fromJson=true'); - overrideFeatureFlag('033_rag_template', 'variant'); navigateToNewWorkflowPage(); diff --git a/packages/frontend/editor-ui/src/components/ParameterInputList.vue b/packages/frontend/editor-ui/src/components/ParameterInputList.vue index fd7a020f7b..663f6c351c 100644 --- a/packages/frontend/editor-ui/src/components/ParameterInputList.vue +++ b/packages/frontend/editor-ui/src/components/ParameterInputList.vue @@ -415,13 +415,13 @@ function isCalloutVisible(parameter: INodeProperties): boolean { return true; } -async function onCalloutAction(action: CalloutActionType) { +function onCalloutAction(action: CalloutActionType) { if (action === 'openRagStarterTemplate') { - await openRagStarterTemplate(activeNode.value?.type ?? 'no active node'); + openRagStarterTemplate(activeNode.value?.type ?? 'no active node'); } } -const onCalloutDismiss = async (parameter: INodeProperties) => { +async function onCalloutDismiss(parameter: INodeProperties) { const dismissConfirmed = await message.confirm( i18n.baseText('parameterInputList.callout.dismiss.confirm.text'), { @@ -440,7 +440,7 @@ const onCalloutDismiss = async (parameter: INodeProperties) => { } await dismissCallout(parameter.name); -}; +}