admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 01:56:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Minor improvements to multi-main setup (no-changelog) (#8012)

Browse Source 
- Move webhook, poller and trigger activation logs closer to activation
event
- Enrich response of `/debug/multi-main-setup`
- Ensure workflow updates broadcast activation state changes only if
state changed
- Fix bug on workflow activation after leadership change
- Ensure debug controller is not available in production

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
This commit is contained in:
Iván Ovejero
2023-12-27 16:55:01 +01:00
committed by GitHub
parent f69ddcd796
commit 2c6ffb0153
6 changed files with 93 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/cli/test/integration/debug.controller.test.ts
View File

@@ -25,22 +25,39 @@ describe('DebugController', () => {
describe('GET /debug/multi-main-setup', () => {
test('should return multi-main setup details', async () => {
const workflowId = generateNanoId();
const activeWorkflows = [{ id: workflowId, name: randomName() }] as WorkflowEntity[];
const webhooks = [{ id: workflowId, name: randomName() }] as WorkflowEntity[];
const triggersAndPollers = [{ id: workflowId, name: randomName() }] as WorkflowEntity[];
const activationErrors = { [workflowId]: 'Failed to activate' };
const instanceId = 'main-71JdWtq306epIFki';
const leaderKey = 'some-leader-key';
workflowRepository.find.mockResolvedValue(activeWorkflows);
const createQueryBuilder = {
select: () => createQueryBuilder,
innerJoin: () => createQueryBuilder,
execute: () => webhooks,
};
workflowRepository.find.mockResolvedValue(triggersAndPollers);
activeWorkflowRunner.allActiveInMemory.mockReturnValue([workflowId]);
activeWorkflowRunner.getAllWorkflowActivationErrors.mockResolvedValue(activationErrors);
jest
.spyOn(workflowRepository, 'createQueryBuilder')
.mockImplementation(() => createQueryBuilder);
jest.spyOn(MultiMainSetup.prototype, 'instanceId', 'get').mockReturnValue(instanceId);
jest.spyOn(MultiMainSetup.prototype, 'fetchLeaderKey').mockResolvedValue('some-leader-key');
jest.spyOn(MultiMainSetup.prototype, 'fetchLeaderKey').mockResolvedValue(leaderKey);
jest.spyOn(MultiMainSetup.prototype, 'isLeader', 'get').mockReturnValue(true);
const response = await ownerAgent.get('/debug/multi-main-setup').expect(200);
expect(response.body.data).toMatchObject({
instanceId,
leaderKey: 'some-leader-key',
activeWorkflows,
leaderKey,
isLeader: true,
activeWorkflows: {
webhooks,
triggersAndPollers,
},
activationErrors,
});
});