admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 18:41:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Correctly allow sharees to test credential when opening the modal (#6111)

Browse Source 
* fix: Prevent incorrect error message when sharee opens a credential

* test: Add testing for automated credential testing

* chore: Remove unnecessary comments
This commit is contained in:
Omar Ajoue
2023-04-28 12:02:28 +02:00
committed by GitHub
parent 206b6b90b8
commit 2e73f4abd0
5 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
View File

@@ -256,7 +256,9 @@ export default mixins(showMessage, nodeHelpers).extend({
setTimeout(() => {
if (this.credentialId) {
if (!this.requiredPropertiesFilled) {
if (!this.requiredPropertiesFilled && this.credentialPermissions.isOwner === true) {
// sharees can't see properties, so this check would always fail for them
// if the credential contains required fields.
this.showValidationWarning = true;
} else {
this.retestCredential();
@@ -347,6 +349,10 @@ export default mixins(showMessage, nodeHelpers).extend({
};
},
isCredentialTestable(): boolean {
// Sharees can always test since they can't see the data.
if (this.credentialPermissions.isOwner === false) {
return true;
}
if (this.isOAuthType || !this.requiredPropertiesFilled) {
return false;
}