admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)

Browse Source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2023-04-24 11:17:08 +00:00
committed by GitHub
parent 03be725cef
commit 308a94311f
31 changed files with 148 additions and 209 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/nodes-base/nodes/Google/BigQuery/test/v2/node/executeQuery.test.ts
View File

@@ -14,21 +14,20 @@ jest.mock('../../../v2/transport', () => {
...originalModule,
googleApiRequest: jest.fn(async (method: string, resource: string) => {
if (resource === '/v2/projects/test-project/jobs' && method === 'POST') {
return Promise.resolve({
return {
jobReference: {
jobId: 'job_123',
},
status: {
state: 'DONE',
},
});
};
}
if (resource === '/v2/projects/test-project/queries/job_123' && method === 'GET') {
return Promise.resolve({});
return {};
}
return Promise.resolve();
}),
// googleApiRequestAllItems: jest.fn(async () => Promise.resolve()),
// googleApiRequestAllItems: jest.fn(async () => {}),
};
});

9
packages/nodes-base/nodes/Google/BigQuery/test/v2/node/insert.autoMapMode.test.ts
View File

@@ -17,25 +17,24 @@ jest.mock('../../../v2/transport', () => {
'/v2/projects/test-project/datasets/bigquery_node_dev_test_dataset/tables/num_text' &&
method === 'GET'
) {
return Promise.resolve({
return {
schema: {
fields: [
{ name: 'id', type: 'INT' },
{ name: 'test', type: 'STRING' },
],
},
});
};
}
if (
resource ===
'/v2/projects/test-project/datasets/bigquery_node_dev_test_dataset/tables/num_text/insertAll' &&
method === 'POST'
) {
return Promise.resolve({ kind: 'bigquery#tableDataInsertAllResponse' });
return { kind: 'bigquery#tableDataInsertAllResponse' };
}
return Promise.resolve();
}),
googleApiRequestAllItems: jest.fn(async () => Promise.resolve()),
googleApiRequestAllItems: jest.fn(async () => {}),
};
});

11
packages/nodes-base/nodes/Google/BigQuery/test/v2/node/insert.manualMode.test.ts
View File

@@ -17,7 +17,7 @@ jest.mock('../../../v2/transport', () => {
'/v2/projects/test-project/datasets/bigquery_node_dev_test_dataset/tables/test_json' &&
method === 'GET'
) {
return Promise.resolve({
return {
schema: {
fields: [
{ name: 'json', type: 'JSON' },
@@ -25,22 +25,21 @@ jest.mock('../../../v2/transport', () => {
{ name: 'active', type: 'BOOLEAN' },
],
},
});
};
}
if (
resource ===
'/v2/projects/test-project/datasets/bigquery_node_dev_test_dataset/tables/test_json/insertAll' &&
method === 'POST'
) {
return Promise.resolve({ kind: 'bigquery#tableDataInsertAllResponse' });
return { kind: 'bigquery#tableDataInsertAllResponse' };
}
return Promise.resolve();
}),
googleApiRequestAllItems: jest.fn(async () => Promise.resolve()),
googleApiRequestAllItems: jest.fn(async () => {}),
};
});
describe('Test Google BigQuery V2, insert define manualy', () => {
describe('Test Google BigQuery V2, insert define manually', () => {
const workflows = ['nodes/Google/BigQuery/test/v2/node/insert.manualMode.workflow.json'];
const tests = workflowToTests(workflows);