admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 10:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Require mfa code to disable mfa (#10345)

Browse Source
This commit is contained in:
Tomi Turtiainen
2024-08-13 15:56:54 +03:00
committed by GitHub
parent e950df0de8
commit 3384f52a35
17 changed files with 215 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/cli/src/controllers/__tests__/me.controller.test.ts
View File

@@ -17,7 +17,7 @@ import { badPasswords } from '@test/testData';
import { mockInstance } from '@test/mocking';
import { AuthUserRepository } from '@/databases/repositories/authUser.repository';
import { MfaService } from '@/Mfa/mfa.service';
import { ForbiddenError } from '@/errors/response-errors/forbidden.error';
import { InvalidMfaCodeError } from '@/errors/response-errors/invalid-mfa-code.error';
const browserId = 'test-browser-id';
@@ -230,16 +230,14 @@ describe('MeController', () => {
);
});
it('should throw ForbiddenError if invalid mfa code is given', async () => {
it('should throw InvalidMfaCodeError if invalid mfa code is given', async () => {
const req = mock<MeRequest.Password>({
user: mock({ password: passwordHash, mfaEnabled: true }),
body: { currentPassword: 'old_password', newPassword: 'NewPassword123', mfaCode: '123' },
});
mockMfaService.validateMfa.mockResolvedValue(false);
await expect(controller.updatePassword(req, mock())).rejects.toThrowError(
new ForbiddenError('Invalid two-factor code.'),
);
await expect(controller.updatePassword(req, mock())).rejects.toThrow(InvalidMfaCodeError);
});
it('should succeed when mfa code is correct', async () => {