admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Decouple community packages from security audit (#17818)

Browse Source
This commit is contained in:
Iván Ovejero
2025-08-05 15:55:31 +02:00
committed by GitHub
parent bac61a7e0d
commit 3eb9367add
3 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/cli/src/security-audit/risk-reporters/nodes-risk-reporter.ts
View File

@@ -1,4 +1,4 @@
import { Container, Service } from '@n8n/di'; import { Service } from '@n8n/di';
import glob from 'fast-glob'; import glob from 'fast-glob';
import type { IWorkflowBase } from 'n8n-workflow'; import type { IWorkflowBase } from 'n8n-workflow';
import * as path from 'path'; import * as path from 'path';
@@ -13,14 +13,14 @@ import {
} from '@/security-audit/constants'; } from '@/security-audit/constants';
import type { Risk, RiskReporter } from '@/security-audit/types'; import type { Risk, RiskReporter } from '@/security-audit/types';
import { getNodeTypes } from '@/security-audit/utils'; import { getNodeTypes } from '@/security-audit/utils';
import { CommunityPackagesService } from '@/community-packages/community-packages.service';
import { CommunityPackagesConfig } from '@/community-packages/community-packages.config'; import { PackagesRepository } from '../security-audit.repository';
@Service() @Service()
export class NodesRiskReporter implements RiskReporter { export class NodesRiskReporter implements RiskReporter {
constructor( constructor(
private readonly loadNodesAndCredentials: LoadNodesAndCredentials, private readonly loadNodesAndCredentials: LoadNodesAndCredentials,
private readonly communityPackagesService: CommunityPackagesService, private readonly packagesRepository: PackagesRepository,
) {} ) {}
async report(workflows: IWorkflowBase[]) { async report(workflows: IWorkflowBase[]) {
@@ -86,9 +86,7 @@ export class NodesRiskReporter implements RiskReporter {
} }
private async getCommunityNodeDetails() { private async getCommunityNodeDetails() {
if (!Container.get(CommunityPackagesConfig).enabled) return []; const installedPackages = await this.packagesRepository.find({ relations: ['installedNodes'] });
const installedPackages = await this.communityPackagesService.getAllInstalledPackages();
return installedPackages.reduce<Risk.CommunityNodeDetails[]>((acc, pkg) => { return installedPackages.reduce<Risk.CommunityNodeDetails[]>((acc, pkg) => {
pkg.installedNodes.forEach((node) => pkg.installedNodes.forEach((node) =>

11
packages/cli/src/security-audit/security-audit.repository.ts Normal file
View File

@@ -0,0 +1,11 @@
import { InstalledPackages } from '@n8n/db';
import { Service } from '@n8n/di';
// eslint-disable-next-line n8n-local-rules/misplaced-n8n-typeorm-import
import { DataSource, Repository } from '@n8n/typeorm';
@Service()
export class PackagesRepository extends Repository<InstalledPackages> {
constructor(dataSource: DataSource) {
super(InstalledPackages, dataSource.manager);
}
}

8
packages/cli/test/integration/security-audit/nodes-risk-reporter.test.ts
View File

@@ -7,6 +7,7 @@ import { v4 as uuid } from 'uuid';
import { LoadNodesAndCredentials } from '@/load-nodes-and-credentials'; import { LoadNodesAndCredentials } from '@/load-nodes-and-credentials';
import { NodeTypes } from '@/node-types'; import { NodeTypes } from '@/node-types';
import { OFFICIAL_RISKY_NODE_TYPES, NODES_REPORT } from '@/security-audit/constants'; import { OFFICIAL_RISKY_NODE_TYPES, NODES_REPORT } from '@/security-audit/constants';
import { PackagesRepository } from '@/security-audit/security-audit.repository';
import { SecurityAuditService } from '@/security-audit/security-audit.service'; import { SecurityAuditService } from '@/security-audit/security-audit.service';
import { toReportTitle } from '@/security-audit/utils'; import { toReportTitle } from '@/security-audit/utils';
import { CommunityPackagesService } from '@/community-packages/community-packages.service'; import { CommunityPackagesService } from '@/community-packages/community-packages.service';
@@ -18,6 +19,7 @@ nodesAndCredentials.getCustomDirectories.mockReturnValue([]);
mockInstance(NodeTypes); mockInstance(NodeTypes);
const communityPackagesService = mockInstance(CommunityPackagesService); const communityPackagesService = mockInstance(CommunityPackagesService);
Container.set(CommunityPackagesService, communityPackagesService); Container.set(CommunityPackagesService, communityPackagesService);
const packagesRepository = mockInstance(PackagesRepository);
let securityAuditService: SecurityAuditService; let securityAuditService: SecurityAuditService;
@@ -37,7 +39,7 @@ afterAll(async () => {
}); });
test('should report risky official nodes', async () => { test('should report risky official nodes', async () => {
communityPackagesService.getAllInstalledPackages.mockResolvedValue(MOCK_PACKAGE); packagesRepository.find.mockResolvedValue(MOCK_PACKAGE);
const map = [...OFFICIAL_RISKY_NODE_TYPES].reduce<{ [nodeType: string]: string }>((acc, cur) => { const map = [...OFFICIAL_RISKY_NODE_TYPES].reduce<{ [nodeType: string]: string }>((acc, cur) => {
return (acc[cur] = uuid()), acc; return (acc[cur] = uuid()), acc;
}, {}); }, {});
@@ -82,7 +84,7 @@ test('should report risky official nodes', async () => {
}); });
test('should not report non-risky official nodes', async () => { test('should not report non-risky official nodes', async () => {
communityPackagesService.getAllInstalledPackages.mockResolvedValue(MOCK_PACKAGE); packagesRepository.find.mockResolvedValue(MOCK_PACKAGE);
await saveManualTriggerWorkflow(); await saveManualTriggerWorkflow();
const testAudit = await securityAuditService.run(['nodes']); const testAudit = await securityAuditService.run(['nodes']);
@@ -99,7 +101,7 @@ test('should not report non-risky official nodes', async () => {
}); });
test('should report community nodes', async () => { test('should report community nodes', async () => {
communityPackagesService.getAllInstalledPackages.mockResolvedValue(MOCK_PACKAGE); packagesRepository.find.mockResolvedValue(MOCK_PACKAGE);
const testAudit = await securityAuditService.run(['nodes']); const testAudit = await securityAuditService.run(['nodes']);