admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Switch multiprocessing context to fork in native Python runner (#19402)

Browse Source
This commit is contained in:
Iván Ovejero
2025-09-11 14:49:40 +02:00
committed by GitHub
parent b91219ea15
commit 41aa8b4ec6
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/@n8n/task-runner-python/src/task_executor.py
View File

@@ -25,7 +25,7 @@ from typing import Any, Set
from multiprocessing.context import SpawnProcess from multiprocessing.context import SpawnProcess
MULTIPROCESSING_CONTEXT = multiprocessing.get_context("spawn") MULTIPROCESSING_CONTEXT = multiprocessing.get_context("fork")
MAX_PRINT_ARGS_ALLOWED = 100 MAX_PRINT_ARGS_ALLOWED = 100
PrintArgs = list[list[Any]] # Args to all `print()` calls in a Python code task PrintArgs = list[list[Any]] # Args to all `print()` calls in a Python code task
@@ -95,6 +95,9 @@ class TaskExecutor:
returned = queue.get_nowait() returned = queue.get_nowait()
except Empty: except Empty:
raise TaskResultMissingError() raise TaskResultMissingError()
finally:
queue.close()
queue.join_thread()
if "error" in returned: if "error" in returned:
raise TaskRuntimeError(returned["error"]) raise TaskRuntimeError(returned["error"])

2
packages/@n8n/task-runner-python/tests/integration/test_execution.py
View File

@@ -187,7 +187,7 @@ async def test_timeout_during_execution(broker, manager):
task_settings = create_task_settings(code=code, node_mode="all_items") task_settings = create_task_settings(code=code, node_mode="all_items")
await broker.send_task(task_id=task_id, task_settings=task_settings) await broker.send_task(task_id=task_id, task_settings=task_settings)
error_msg = await wait_for_task_error(broker, task_id, timeout=TASK_TIMEOUT + 0.5) error_msg = await wait_for_task_error(broker, task_id, timeout=TASK_TIMEOUT + 1.5)
assert error_msg["taskId"] == task_id assert error_msg["taskId"] == task_id
assert "timed out" in error_msg["error"]["message"].lower() assert "timed out" in error_msg["error"]["message"].lower()