OAuth2 credentials, genericFunctions modded, oauth2 ui changes

packages/nodes-base/credentials/PagerDutyOAuth2Api.credentials.ts

@@ -0,0 +1,39 @@
+import {
+	ICredentialType,
+	NodePropertyTypes,
+} from 'n8n-workflow';
+
+export class PagerDutyOAuth2Api implements ICredentialType {
+	name = 'pagerDutyOAuth2Api';
+	extends = [
+		'oAuth2Api',
+	];
+	displayName = 'PagerDuty OAuth2 API';
+	properties = [
+		{
+			displayName: 'Authorization URL',
+			name: 'authUrl',
+			type: 'hidden' as NodePropertyTypes,
+			default: 'https://app.pagerduty.com/oauth/authorize',
+		},
+		{
+			displayName: 'Access Token URL',
+			name: 'accessTokenUrl',
+			type: 'hidden' as NodePropertyTypes,
+			default: 'https://app.pagerduty.com/oauth/token',
+		},
+		{
+			displayName: 'Auth URI Query Parameters',
+			name: 'authQueryParameters',
+			type: 'hidden' as NodePropertyTypes,
+			default: 'grant_type=authorization_code',
+		},
+		{
+            displayName: 'Authentication',
+            name: 'authentication',
+            type: 'hidden' as NodePropertyTypes,
+            default: 'header',
+            description: 'Method of authentication.',
+        },
+	];
+}

packages/nodes-base/nodes/PagerDuty/GenericFunctions.ts

@@ -19,16 +19,11 @@ import {
 
 export async function pagerDutyApiRequest(this: IExecuteFunctions | IWebhookFunctions | IHookFunctions | ILoadOptionsFunctions, method: string, resource: string, body: any = {}, query: IDataObject = {}, uri?: string, headers: IDataObject = {}): Promise<any> { // tslint:disable-line:no-any
 
-	const credentials = this.getCredentials('pagerDutyApi');
-
-	if (credentials === undefined) {
-		throw new Error('No credentials got returned!');
-	}
+	const authenticationMethod = this.getNodeParameter('authentication', 0);
 
 	const options: OptionsWithUri = {
 		headers: {
-			Accept: 'application/vnd.pagerduty+json;version=2',
-			Authorization: `Token token=${credentials.apiToken}`,
+			Accept: 'application/vnd.pagerduty+json;version=2'
 		},
 		method,
 		body,
@@ -39,15 +34,30 @@ export async function pagerDutyApiRequest(this: IExecuteFunctions | IWebhookFunc
 			arrayFormat: 'brackets',
 		},
 	};
+
 	if (!Object.keys(body).length) {
 		delete options.form;
 	}
 	if (!Object.keys(query).length) {
 		delete options.qs;
 	}
+
 	options.headers = Object.assign({}, options.headers, headers);
+
 	try {
+		if (authenticationMethod === 'accessToken') {
+			const credentials = this.getCredentials('pagerDutyApi');
+
+			if (credentials === undefined) {
+				throw new Error('No credentials got returned!');
+			}
+
+			options.headers!['Authorization'] = `Token token=${credentials.apiToken}`;
+
 			return await this.helpers.request!(options);
+		} else {
+			return await this.helpers.requestOAuth2!.call(this, 'pagerDutyOAuth2Api', options);
+		}
 	} catch (error) {
 		if (error.response && error.response.body && error.response.body.error && error.response.body.error.errors) {
 			// Try to return the error prettier

packages/nodes-base/nodes/PagerDuty/PagerDuty.node.ts

@@ -66,9 +66,43 @@ export class PagerDuty implements INodeType {
 			{
 				name: 'pagerDutyApi',
 				required: true,
+				displayOptions: {
+					show: {
+						authentication: [
+							'accessToken',
+						],
+					},
+				},
+			},
+			{
+				name: 'pagerDutyOAuth2Api',
+				required: true,
+				displayOptions: {
+					show: {
+						authentication: [
+							'oAuth2',
+						],
+					},
+				},
 			},
 		],
 		properties: [
+			{
+				displayName: 'Authentication',
+				name: 'authentication',
+				type: 'options',
+				options: [
+					{
+						name: 'Access Token',
+						value: 'accessToken',
+					},
+					{
+						name: 'OAuth2',
+						value: 'oAuth2',
+					},
+				],
+				default: 'accessToken',
+			},
 			{
 				displayName: 'Resource',
 				name: 'resource',

packages/nodes-base/package.json

@@ -97,6 +97,7 @@
             "dist/credentials/OAuth2Api.credentials.js",
             "dist/credentials/OpenWeatherMapApi.credentials.js",
             "dist/credentials/PagerDutyApi.credentials.js",
+            "dist/credentials/PagerDutyOAuth2Api.credentials.js",
             "dist/credentials/PayPalApi.credentials.js",
             "dist/credentials/PipedriveApi.credentials.js",
             "dist/credentials/Postgres.credentials.js",