admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-24 04:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Fix resolve RL values in expressions (#4173)

Browse Source 
* update interface

* update expression resolving

* 🔥 remove ExtractValue functions

* add flags

* update resolving

* update expr

* fix for list mode

* clean up

* Fix up

* update guard

* fix bug with switching

* update to handle expr referencing

* fix legacy expression

* fix when switching

* update spacing

Co-authored-by: Valya Bullions <valya@n8n.io>
This commit is contained in:
Mutasem Aldmour
2022-09-22 19:04:26 +02:00
committed by GitHub
parent d01f7d4d93
commit 469c391fee
12 changed files with 85 additions and 361 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/nodes-base/nodes/Airtable/Airtable.node.ts
View File

@@ -508,15 +508,8 @@ export class Airtable implements INodeType {
const operation = this.getNodeParameter('operation', 0) as string;
const application = this.getNodeParameter('application', 0, undefined, {
extractValue: true,
}) as string;
const table = encodeURI(
this.getNodeParameter('table', 0, undefined, {
extractValue: true,
}) as string,
);
const application = this.getNodeParameter('application', 0) as string;
const table = encodeURI(this.getNodeParameter('table', 0) as string);
let returnAll = false;
let endpoint = '';

32
packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts
View File

@@ -2153,9 +2153,7 @@ export class GoogleDrive implements INodeType {
// delete
// ----------------------------------
const driveId = this.getNodeParameter('driveId', i, undefined, {
extractValue: true,
}) as string;
const driveId = this.getNodeParameter('driveId', i) as string;
await googleApiRequest.call(this, 'DELETE', `/drive/v3/drives/${driveId}`);
@@ -2171,9 +2169,7 @@ export class GoogleDrive implements INodeType {
// get
// ----------------------------------
const driveId = this.getNodeParameter('driveId', i, undefined, {
extractValue: true,
}) as string;
const driveId = this.getNodeParameter('driveId', i) as string;
const qs: IDataObject = {};
@@ -2233,9 +2229,7 @@ export class GoogleDrive implements INodeType {
// update
// ----------------------------------
const driveId = this.getNodeParameter('driveId', i, undefined, {
extractValue: true,
}) as string;
const driveId = this.getNodeParameter('driveId', i) as string;
const body: IDataObject = {};
@@ -2262,9 +2256,7 @@ export class GoogleDrive implements INodeType {
// copy
// ----------------------------------
const fileId = this.getNodeParameter('fileId', i, undefined, {
extractValue: true,
}) as string;
const fileId = this.getNodeParameter('fileId', i) as string;
const body: IDataObject = {
fields: queryFields,
@@ -2300,9 +2292,7 @@ export class GoogleDrive implements INodeType {
// download
// ----------------------------------
const fileId = this.getNodeParameter('fileId', i, undefined, {
extractValue: true,
}) as string;
const fileId = this.getNodeParameter('fileId', i) as string;
const options = this.getNodeParameter('options', i) as IDataObject;
const requestOptions = {
@@ -2645,9 +2635,7 @@ export class GoogleDrive implements INodeType {
// file:update
// ----------------------------------
const id = this.getNodeParameter('fileId', i, undefined, {
extractValue: true,
}) as string;
const id = this.getNodeParameter('fileId', i) as string;
const updateFields = this.getNodeParameter('updateFields', i, {}) as IDataObject;
const qs: IDataObject = {
@@ -2721,9 +2709,7 @@ export class GoogleDrive implements INodeType {
// delete
// ----------------------------------
const fileId = this.getNodeParameter('fileId', i, undefined, {
extractValue: true,
}) as string;
const fileId = this.getNodeParameter('fileId', i) as string;
await googleApiRequest.call(
this,
@@ -2745,9 +2731,7 @@ export class GoogleDrive implements INodeType {
returnData.push(...executionData);
}
if (operation === 'share') {
const fileId = this.getNodeParameter('fileId', i, undefined, {
extractValue: true,
}) as string;
const fileId = this.getNodeParameter('fileId', i) as string;
const permissions = this.getNodeParameter('permissionsUi', i) as IDataObject;

86
packages/nodes-base/nodes/Trello/Trello.node.ts
View File

@@ -239,9 +239,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const id = this.getNodeParameter('id', i, undefined, {
extractValue: true,
}) as string;
const id = this.getNodeParameter('id', i) as string;
endpoint = `boards/${id}`;
} else if (operation === 'get') {
@@ -251,7 +249,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const id = this.getNodeParameter('id', i, undefined, { extractValue: true });
const id = this.getNodeParameter('id', i);
endpoint = `boards/${id}`;
@@ -264,7 +262,7 @@ export class Trello implements INodeType {
requestMethod = 'PUT';
const id = this.getNodeParameter('id', i, undefined, { extractValue: true });
const id = this.getNodeParameter('id', i);
endpoint = `boards/${id}`;
@@ -367,7 +365,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const id = this.getNodeParameter('id', i, undefined, { extractValue: true });
const id = this.getNodeParameter('id', i);
endpoint = `cards/${id}`;
} else if (operation === 'get') {
@@ -377,7 +375,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const id = this.getNodeParameter('id', i, undefined, { extractValue: true });
const id = this.getNodeParameter('id', i);
endpoint = `cards/${id}`;
@@ -390,7 +388,7 @@ export class Trello implements INodeType {
requestMethod = 'PUT';
const id = this.getNodeParameter('id', i, undefined, { extractValue: true });
const id = this.getNodeParameter('id', i);
endpoint = `cards/${id}`;
@@ -409,9 +407,7 @@ export class Trello implements INodeType {
// create
// ----------------------------------
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
qs.text = this.getNodeParameter('text', i) as string;
@@ -425,9 +421,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const commentId = this.getNodeParameter('commentId', i) as string;
@@ -439,9 +433,7 @@ export class Trello implements INodeType {
requestMethod = 'PUT';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const commentId = this.getNodeParameter('commentId', i) as string;
@@ -560,9 +552,7 @@ export class Trello implements INodeType {
requestMethod = 'POST';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const url = this.getNodeParameter('url', i) as string;
@@ -581,9 +571,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const id = this.getNodeParameter('id', i) as string;
@@ -595,9 +583,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const id = this.getNodeParameter('id', i) as string;
@@ -612,9 +598,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
endpoint = `cards/${cardId}/attachments`;
@@ -635,9 +619,7 @@ export class Trello implements INodeType {
requestMethod = 'POST';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const name = this.getNodeParameter('name', i) as string;
@@ -654,9 +636,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const id = this.getNodeParameter('id', i) as string;
@@ -681,9 +661,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
endpoint = `cards/${cardId}/checklists`;
@@ -696,9 +674,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const checkItemId = this.getNodeParameter('checkItemId', i) as string;
@@ -727,9 +703,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const checkItemId = this.getNodeParameter('checkItemId', i) as string;
@@ -741,9 +715,7 @@ export class Trello implements INodeType {
requestMethod = 'PUT';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const checkItemId = this.getNodeParameter('checkItemId', i) as string;
@@ -758,9 +730,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
endpoint = `cards/${cardId}/checkItemStates`;
@@ -781,9 +751,7 @@ export class Trello implements INodeType {
requestMethod = 'POST';
const idBoard = this.getNodeParameter('boardId', i, undefined, {
extractValue: true,
}) as string;
const idBoard = this.getNodeParameter('boardId', i) as string;
const name = this.getNodeParameter('name', i) as string;
const color = this.getNodeParameter('color', i) as string;
@@ -825,9 +793,7 @@ export class Trello implements INodeType {
requestMethod = 'GET';
const idBoard = this.getNodeParameter('boardId', i, undefined, {
extractValue: true,
}) as string;
const idBoard = this.getNodeParameter('boardId', i) as string;
endpoint = `board/${idBoard}/labels`;
@@ -854,9 +820,7 @@ export class Trello implements INodeType {
requestMethod = 'POST';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const id = this.getNodeParameter('id', i) as string;
@@ -870,9 +834,7 @@ export class Trello implements INodeType {
requestMethod = 'DELETE';
const cardId = this.getNodeParameter('cardId', i, undefined, {
extractValue: true,
}) as string;
const cardId = this.getNodeParameter('cardId', i) as string;
const id = this.getNodeParameter('id', i) as string;