From 48588194b9f193eb52c8b5fd4d4d4f92bbfe7dc3 Mon Sep 17 00:00:00 2001
From: oleg <me@olegivaniv.com>
Date: Fri, 17 May 2024 11:52:15 +0200
Subject: [PATCH] refactor(editor): Fix Types issues in @n8n/chat
 (no-changelog) (#9438)

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---
 packages/@n8n/chat/src/components/Chat.vue       |  1 -
 packages/@n8n/chat/src/components/ChatWindow.vue |  2 --
 packages/@n8n/chat/src/components/Input.vue      |  1 -
 packages/@n8n/chat/src/types/icons.d.ts          |  5 +++++
 packages/@n8n/chat/vite.config.ts                |  1 +
 packages/@n8n_io/eslint-config/base.js           |  2 +-
 packages/editor-ui/tsconfig.json                 |  2 +-
 packages/editor-ui/vite.config.mts               |  1 +
 pnpm-lock.yaml                                   | 12 ++++++------
 9 files changed, 15 insertions(+), 12 deletions(-)
 create mode 100644 packages/@n8n/chat/src/types/icons.d.ts

diff --git a/packages/@n8n/chat/src/components/Chat.vue b/packages/@n8n/chat/src/components/Chat.vue
index c6b0a08618..685b0805bc 100644
--- a/packages/@n8n/chat/src/components/Chat.vue
+++ b/packages/@n8n/chat/src/components/Chat.vue
@@ -1,5 +1,4 @@
 <script setup lang="ts">
-// eslint-disable-next-line import/no-unresolved
 import Close from 'virtual:icons/mdi/close';
 import { computed, nextTick, onMounted } from 'vue';
 import Layout from '@n8n/chat/components/Layout.vue';
diff --git a/packages/@n8n/chat/src/components/ChatWindow.vue b/packages/@n8n/chat/src/components/ChatWindow.vue
index 1d1f7ae3c2..8e0d05daf8 100644
--- a/packages/@n8n/chat/src/components/ChatWindow.vue
+++ b/packages/@n8n/chat/src/components/ChatWindow.vue
@@ -1,7 +1,5 @@
 <script lang="ts" setup>
-// eslint-disable-next-line import/no-unresolved
 import IconChat from 'virtual:icons/mdi/chat';
-// eslint-disable-next-line import/no-unresolved
 import IconChevronDown from 'virtual:icons/mdi/chevron-down';
 import { nextTick, ref } from 'vue';
 import Chat from '@n8n/chat/components/Chat.vue';
diff --git a/packages/@n8n/chat/src/components/Input.vue b/packages/@n8n/chat/src/components/Input.vue
index 0f87463690..d393ab90ed 100644
--- a/packages/@n8n/chat/src/components/Input.vue
+++ b/packages/@n8n/chat/src/components/Input.vue
@@ -1,5 +1,4 @@
 <script setup lang="ts">
-// eslint-disable-next-line import/no-unresolved
 import IconSend from 'virtual:icons/mdi/send';
 import { computed, onMounted, ref } from 'vue';
 import { useI18n, useChat, useOptions } from '@n8n/chat/composables';
diff --git a/packages/@n8n/chat/src/types/icons.d.ts b/packages/@n8n/chat/src/types/icons.d.ts
new file mode 100644
index 0000000000..e1dbd9c3db
--- /dev/null
+++ b/packages/@n8n/chat/src/types/icons.d.ts
@@ -0,0 +1,5 @@
+declare module 'virtual:icons/*' {
+	import { FunctionalComponent, SVGAttributes } from 'vue';
+	const component: FunctionalComponent<SVGAttributes>;
+	export default component;
+}
diff --git a/packages/@n8n/chat/vite.config.ts b/packages/@n8n/chat/vite.config.ts
index ecb096c5e2..847a224303 100644
--- a/packages/@n8n/chat/vite.config.ts
+++ b/packages/@n8n/chat/vite.config.ts
@@ -14,6 +14,7 @@ const plugins = [
 	vue(),
 	icons({
 		compiler: 'vue3',
+		autoInstall: true,
 	}),
 	dts(),
 ];
diff --git a/packages/@n8n_io/eslint-config/base.js b/packages/@n8n_io/eslint-config/base.js
index ce8cab9007..232664d7f1 100644
--- a/packages/@n8n_io/eslint-config/base.js
+++ b/packages/@n8n_io/eslint-config/base.js
@@ -361,7 +361,7 @@ const config = (module.exports = {
 		/**
 		 * https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-unresolved.md
 		 */
-		'import/no-unresolved': 'error',
+		'import/no-unresolved': ['error', { ignore: ['^virtual:'] }],
 
 		/**
 		 * https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/order.md
diff --git a/packages/editor-ui/tsconfig.json b/packages/editor-ui/tsconfig.json
index 361eadcf44..afc545aea9 100644
--- a/packages/editor-ui/tsconfig.json
+++ b/packages/editor-ui/tsconfig.json
@@ -1,7 +1,7 @@
 {
 	"extends": "../../tsconfig.json",
 	"compilerOptions": {
-		"rootDir": ".",
+		"rootDirs": [".", "../design-system/src", "../@n8n/chat/src"],
 		"outDir": "dist",
 		"target": "esnext",
 		"module": "esnext",
diff --git a/packages/editor-ui/vite.config.mts b/packages/editor-ui/vite.config.mts
index b1556d8c08..6fc8bc12b9 100644
--- a/packages/editor-ui/vite.config.mts
+++ b/packages/editor-ui/vite.config.mts
@@ -73,6 +73,7 @@ const alias = [
 const plugins = [
 	icons({
 		compiler: 'vue3',
+		autoInstall: true,
 	}),
 	vue(),
 ];
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 6b3427c96b..dc17b5847a 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -4560,7 +4560,7 @@ packages:
     resolution: {integrity: sha512-X7yV7eiwAxdj9k94NEylvbVHLiVG1nvzCV2EAowhxLTwODV1jl9UzZ48leOC0sH7OnuHrIkllaBgneUykIcZaw==}
     engines: {node: '>=6.9.0'}
     dependencies:
-      '@babel/code-frame': 7.22.5
+      '@babel/code-frame': 7.23.5
       '@babel/parser': 7.24.0
       '@babel/types': 7.24.0
 
@@ -8883,7 +8883,7 @@ packages:
       lodash: 4.17.21
       prettier: 3.2.5
       recast: 0.23.6
-      tiny-invariant: 1.3.1
+      tiny-invariant: 1.3.3
     transitivePeerDependencies:
       - supports-color
     dev: true
@@ -9261,7 +9261,7 @@ packages:
       ts-dedent: 2.2.0
       type-fest: 2.19.0
       vue: 3.4.21(typescript@5.4.2)
-      vue-component-type-helpers: 2.0.18
+      vue-component-type-helpers: 2.0.19
     transitivePeerDependencies:
       - encoding
       - supports-color
@@ -24125,7 +24125,7 @@ packages:
       npm-run-path: 4.0.1
       semver: 7.6.0
       strip-ansi: 6.0.1
-      tiny-invariant: 1.3.1
+      tiny-invariant: 1.3.3
       typescript: 5.4.2
       vite: 5.1.6(sass@1.64.1)
       vscode-languageclient: 7.0.0
@@ -24344,8 +24344,8 @@ packages:
     resolution: {integrity: sha512-0vOfAtI67UjeO1G6UiX5Kd76CqaQ67wrRZiOe7UAb9Jm6GzlUr/fC7CV90XfwapJRjpCMaZFhv1V0ajWRmE9Dg==}
     dev: true
 
-  /vue-component-type-helpers@2.0.18:
-    resolution: {integrity: sha512-zi1QaDBhSb3oeHJh55aTCrosFNKEQsOL9j3XCAjpF9dwxDUUtd85RkJVzO+YpJqy1LNoCWLU8gwuZ7HW2iDN/A==}
+  /vue-component-type-helpers@2.0.19:
+    resolution: {integrity: sha512-cN3f1aTxxKo4lzNeQAkVopswuImUrb5Iurll9Gaw5cqpnbTAxtEMM1mgi6ou4X79OCyqYv1U1mzBHJkzmiK82w==}
     dev: true
 
   /vue-demi@0.14.5(vue@3.4.21):