fix(editor): Stop nefarious redirects during sign in (#16034)

This commit is contained in:
Marc Littlemore
2025-06-05 08:31:55 +01:00
committed by GitHub
parent 02ed7b6631
commit 4865d1e360
2 changed files with 123 additions and 17 deletions

View File

@@ -101,7 +101,19 @@ const onEmailPasswordSubmitted = async (form: EmailOrLdapLoginIdAndPassword) =>
const isRedirectSafe = () => {
const redirect = getRedirectQueryParameter();
return redirect.startsWith('/') || redirect.startsWith(window.location.origin);
// Allow local redirects
if (redirect.startsWith('/')) {
return true;
}
try {
// Only allow origin domain redirects
const url = new URL(redirect);
return url.origin === window.location.origin;
} catch {
return false;
}
};
const getRedirectQueryParameter = () => {