admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Comply with custom default for workflow saving settings (#7634)

Browse Source 
https://linear.app/n8n/issue/PAY-982
This commit is contained in:
Iván Ovejero
2023-11-07 16:26:55 +01:00
committed by GitHub
parent ac877014ed
commit 48c068f97b
2 changed files with 86 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
packages/cli/test/unit/execution.lifecycle.test.ts
View File

@@ -145,43 +145,96 @@ for (const mode of ['filesystem-v2', 's3'] as const) {
describe('toSaveSettings()', () => {
afterEach(() => {
jest.restoreAllMocks();
config.load(config.default);
});
it('should set `error` based on workflow settings', () => {
const saveSettings = toSaveSettings({ saveDataErrorExecution: 'all' });
describe('when setting `error`', () => {
it('should favor workflow settings over defaults', () => {
config.set('executions.saveDataOnError', 'none');
expect(saveSettings.error).toBe(true);
const saveSettings = toSaveSettings({ saveDataErrorExecution: 'all' });
const _saveSettings = toSaveSettings({ saveDataErrorExecution: 'none' });
expect(saveSettings.error).toBe(true);
expect(_saveSettings.error).toBe(false);
config.set('executions.saveDataOnError', 'all');
const _saveSettings = toSaveSettings({ saveDataErrorExecution: 'none' });
expect(_saveSettings.error).toBe(false);
});
it('should fall back to default if no workflow setting', () => {
config.set('executions.saveDataOnError', 'all');
const saveSettings = toSaveSettings();
expect(saveSettings.error).toBe(true);
config.set('executions.saveDataOnError', 'none');
const _saveSettings = toSaveSettings();
expect(_saveSettings.error).toBe(false);
});
});
it('should set `success` based on workflow settings', () => {
const saveSettings = toSaveSettings({ saveDataSuccessExecution: 'all' });
describe('when setting `success`', () => {
it('should favor workflow settings over defaults', () => {
config.set('executions.saveDataOnSuccess', 'none');
expect(saveSettings.success).toBe(true);
const saveSettings = toSaveSettings({ saveDataSuccessExecution: 'all' });
const _saveSettings = toSaveSettings({ saveDataSuccessExecution: 'none' });
expect(saveSettings.success).toBe(true);
expect(_saveSettings.success).toBe(false);
config.set('executions.saveDataOnSuccess', 'all');
const _saveSettings = toSaveSettings({ saveDataSuccessExecution: 'none' });
expect(_saveSettings.success).toBe(false);
});
it('should fall back to default if no workflow setting', () => {
config.set('executions.saveDataOnSuccess', 'all');
const saveSettings = toSaveSettings();
expect(saveSettings.success).toBe(true);
config.set('executions.saveDataOnSuccess', 'none');
const _saveSettings = toSaveSettings();
expect(_saveSettings.success).toBe(false);
});
});
it('should set `manual` based on workflow settings', () => {
const saveSettings = toSaveSettings({ saveManualExecutions: true });
describe('when setting `manual`', () => {
it('should favor workflow settings over defaults', () => {
config.set('executions.saveDataManualExecutions', false);
expect(saveSettings.manual).toBe(true);
const saveSettings = toSaveSettings({ saveManualExecutions: true });
const _saveSettings = toSaveSettings({ saveManualExecutions: false });
expect(saveSettings.manual).toBe(true);
expect(_saveSettings.manual).toBe(false);
});
config.set('executions.saveDataManualExecutions', true);
it('should return defaults if no workflow settings', async () => {
const saveSettings = toSaveSettings();
const _saveSettings = toSaveSettings({ saveManualExecutions: false });
expect(saveSettings.error).toBe(true);
expect(saveSettings.success).toBe(true);
expect(saveSettings.manual).toBe(true);
expect(_saveSettings.manual).toBe(false);
});
it('should fall back to default if no workflow setting', () => {
config.set('executions.saveDataManualExecutions', true);
const saveSettings = toSaveSettings();
expect(saveSettings.manual).toBe(true);
config.set('executions.saveDataManualExecutions', false);
const _saveSettings = toSaveSettings();
expect(_saveSettings.manual).toBe(false);
});
});
});