feat(editor): Forbid focusing on node settings parameter (no-changelog) (#17193)

This commit is contained in:
Daria
2025-07-10 15:00:17 +03:00
committed by GitHub
parent 3926696709
commit 4b945a028c
2 changed files with 10 additions and 1 deletions

View File

@@ -435,6 +435,7 @@ const populateSettings = () => {
default: false, default: false,
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.alwaysOutputData.description'), description: i18n.baseText('nodeSettings.alwaysOutputData.description'),
isNodeSetting: true,
}, },
{ {
displayName: i18n.baseText('nodeSettings.executeOnce.displayName'), displayName: i18n.baseText('nodeSettings.executeOnce.displayName'),
@@ -443,6 +444,7 @@ const populateSettings = () => {
default: false, default: false,
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.executeOnce.description'), description: i18n.baseText('nodeSettings.executeOnce.description'),
isNodeSetting: true,
}, },
{ {
displayName: i18n.baseText('nodeSettings.retryOnFail.displayName'), displayName: i18n.baseText('nodeSettings.retryOnFail.displayName'),
@@ -451,6 +453,7 @@ const populateSettings = () => {
default: false, default: false,
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.retryOnFail.description'), description: i18n.baseText('nodeSettings.retryOnFail.description'),
isNodeSetting: true,
}, },
{ {
displayName: i18n.baseText('nodeSettings.maxTries.displayName'), displayName: i18n.baseText('nodeSettings.maxTries.displayName'),
@@ -468,6 +471,7 @@ const populateSettings = () => {
}, },
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.maxTries.description'), description: i18n.baseText('nodeSettings.maxTries.description'),
isNodeSetting: true,
}, },
{ {
displayName: i18n.baseText('nodeSettings.waitBetweenTries.displayName'), displayName: i18n.baseText('nodeSettings.waitBetweenTries.displayName'),
@@ -485,6 +489,7 @@ const populateSettings = () => {
}, },
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.waitBetweenTries.description'), description: i18n.baseText('nodeSettings.waitBetweenTries.description'),
isNodeSetting: true,
}, },
{ {
displayName: i18n.baseText('nodeSettings.onError.displayName'), displayName: i18n.baseText('nodeSettings.onError.displayName'),
@@ -514,6 +519,7 @@ const populateSettings = () => {
default: 'stopWorkflow', default: 'stopWorkflow',
description: i18n.baseText('nodeSettings.onError.description'), description: i18n.baseText('nodeSettings.onError.description'),
noDataExpression: true, noDataExpression: true,
isNodeSetting: true,
}, },
] as INodeProperties[]), ] as INodeProperties[]),
); );
@@ -530,6 +536,7 @@ const populateSettings = () => {
default: '', default: '',
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.notes.description'), description: i18n.baseText('nodeSettings.notes.description'),
isNodeSetting: true,
}, },
{ {
displayName: i18n.baseText('nodeSettings.notesInFlow.displayName'), displayName: i18n.baseText('nodeSettings.notesInFlow.displayName'),
@@ -538,6 +545,7 @@ const populateSettings = () => {
default: false, default: false,
noDataExpression: true, noDataExpression: true,
description: i18n.baseText('nodeSettings.notesInFlow.description'), description: i18n.baseText('nodeSettings.notesInFlow.description'),
isNodeSetting: true,
}, },
] as INodeProperties[]), ] as INodeProperties[]),
); );

View File

@@ -90,8 +90,9 @@ const isFocusPanelFeatureEnabled = computed(() => {
const hasFocusAction = computed( const hasFocusAction = computed(
() => () =>
isFocusPanelFeatureEnabled.value && isFocusPanelFeatureEnabled.value &&
!props.parameter.isNodeSetting &&
!props.isReadOnly && !props.isReadOnly &&
activeNode.value && activeNode.value && // checking that it's inside ndv
(props.parameter.type === 'string' || props.parameter.type === 'json'), (props.parameter.type === 'string' || props.parameter.type === 'json'),
); );