refactor: Enable import/order for design-system, workflow and @n8n packages (#10847)

This commit is contained in:
Tomi Turtiainen
2024-09-18 10:19:33 +03:00
committed by GitHub
parent 5a1db6db1a
commit 4f0a1a953f
305 changed files with 746 additions and 507 deletions

View File

@@ -1,5 +1,5 @@
import type { IDataObject } from '@/Interfaces';
import { augmentArray, augmentObject } from '@/AugmentObject';
import type { IDataObject } from '@/Interfaces';
import { deepCopy } from '@/utils';
describe('AugmentObject', () => {

View File

@@ -3,15 +3,17 @@
*/
import { DateTime, Duration, Interval } from 'luxon';
import { Workflow } from '@/Workflow';
import * as Helpers from './Helpers';
import type { ExpressionTestEvaluation, ExpressionTestTransform } from './ExpressionFixtures/base';
import { baseFixtures } from './ExpressionFixtures/base';
import type { INodeExecutionData } from '@/Interfaces';
import { extendSyntax } from '@/Extensions/ExpressionExtension';
import { ExpressionError } from '@/errors/expression.error';
import { setDifferEnabled, setEvaluator } from '@/ExpressionEvaluatorProxy';
import { extendSyntax } from '@/Extensions/ExpressionExtension';
import type { INodeExecutionData } from '@/Interfaces';
import { Workflow } from '@/Workflow';
import { workflow } from './ExpressionExtensions/Helpers';
import { baseFixtures } from './ExpressionFixtures/base';
import type { ExpressionTestEvaluation, ExpressionTestTransform } from './ExpressionFixtures/base';
import * as Helpers from './Helpers';
setDifferEnabled(true);

View File

@@ -2,8 +2,8 @@
* @jest-environment jsdom
*/
import { arrayExtensions } from '../../src/Extensions/ArrayExtensions';
import { evaluate } from './Helpers';
import { arrayExtensions } from '../../src/Extensions/ArrayExtensions';
describe('Data Transformation Functions', () => {
describe('Array Data Transformation Functions', () => {

View File

@@ -2,8 +2,8 @@
* @jest-environment jsdom
*/
import { booleanExtensions } from '../../src/Extensions/BooleanExtensions';
import { evaluate } from './Helpers';
import { booleanExtensions } from '../../src/Extensions/BooleanExtensions';
describe('Data Transformation Functions', () => {
describe('Boolean Data Transformation Functions', () => {

View File

@@ -3,7 +3,9 @@
*/
import { DateTime } from 'luxon';
import { getGlobalState } from '@/GlobalState';
import { evaluate, getLocalISOString } from './Helpers';
import { dateExtensions } from '../../src/Extensions/DateExtensions';

View File

@@ -6,6 +6,7 @@
import { extendTransform, extend } from '@/Extensions';
import { joinExpression, splitExpression } from '@/Extensions/ExpressionParser';
import { evaluate } from './Helpers';
import { ExpressionExtensionError } from '../../src/errors/expression-extension.error';

View File

@@ -1,5 +1,6 @@
import type { IDataObject } from '@/Interfaces';
import { Workflow } from '@/Workflow';
import * as Helpers from '../Helpers';
export const nodeTypes = Helpers.NodeTypes();

View File

@@ -3,6 +3,7 @@
*/
import { numberExtensions } from '@/Extensions/NumberExtensions';
import { evaluate } from './Helpers';
describe('Data Transformation Functions', () => {

View File

@@ -1,5 +1,5 @@
import { objectExtensions } from '../../src/Extensions/ObjectExtensions';
import { evaluate } from './Helpers';
import { objectExtensions } from '../../src/Extensions/ObjectExtensions';
describe('Data Transformation Functions', () => {
describe('Object Data Transformation Functions', () => {

View File

@@ -2,6 +2,7 @@
* @jest-environment jsdom
*/
import { DateTime } from 'luxon';
import { evaluate } from './Helpers';
import { ExpressionExtensionError } from '../../src/errors';

View File

@@ -1,5 +1,5 @@
import type { GenericValue, IDataObject } from '@/Interfaces';
import { ExpressionError } from '@/errors/expression.error';
import type { GenericValue, IDataObject } from '@/Interfaces';
interface ExpressionTestBase {
type: 'evaluation' | 'transform';

View File

@@ -1,6 +1,7 @@
import { PrototypeSanitizer, sanitizer } from '@/ExpressionSandboxing';
import { Tournament } from '@n8n/tournament';
import { PrototypeSanitizer, sanitizer } from '@/ExpressionSandboxing';
const tournament = new Tournament(
(e) => {
throw e;

View File

@@ -1,8 +1,9 @@
import { arrayContainsValue, executeFilter } from '@/NodeParameters/FilterParameter';
import type { FilterConditionValue, FilterValue } from '@/Interfaces';
import merge from 'lodash/merge';
import { DateTime } from 'luxon';
import type { FilterConditionValue, FilterValue } from '@/Interfaces';
import { arrayContainsValue, executeFilter } from '@/NodeParameters/FilterParameter';
type DeepPartial<T> = {
[P in keyof T]?: T[P] extends object ? DeepPartial<T[P]> : T[P];
};

View File

@@ -1,7 +1,7 @@
import { readFileSync } from 'fs';
import path from 'path';
import { mock } from 'jest-mock-extended';
import get from 'lodash/get';
import path from 'path';
import type {
IExecuteSingleFunctions,
@@ -13,6 +13,7 @@ import type {
IRunExecutionData,
} from '@/Interfaces';
import type { Workflow } from '@/Workflow';
import { NodeTypes as NodeTypesClass } from './NodeTypes';
export function getExecuteSingleFunctions(

View File

@@ -1,6 +1,7 @@
import type { INode, JsonObject } from '@/Interfaces';
import { NodeOperationError } from '@/errors';
import { NodeApiError } from '@/errors/node-api.error';
import type { INode, JsonObject } from '@/Interfaces';
import { UNKNOWN_ERROR_DESCRIPTION, UNKNOWN_ERROR_MESSAGE } from '../src/Constants';
const node: INode = {

View File

@@ -6,7 +6,6 @@ import {
type INodeType,
type INodeTypeDescription,
} from '@/Interfaces';
import type { Workflow } from '@/Workflow';
import {
getNodeParameters,
getNodeHints,
@@ -15,6 +14,7 @@ import {
applyDeclarativeNodeOptionParameters,
convertNodeToAiTool,
} from '@/NodeHelpers';
import type { Workflow } from '@/Workflow';
describe('NodeHelpers', () => {
describe('getNodeParameters', () => {

View File

@@ -1,4 +1,5 @@
import { mock } from 'jest-mock-extended';
import {
NodeConnectionType,
type IDataObject,

View File

@@ -1,3 +1,5 @@
import { mock } from 'jest-mock-extended';
import type {
INode,
INodeExecutionData,
@@ -16,14 +18,12 @@ import type {
IWorkflowExecuteAdditionalData,
IExecuteFunctions,
} from '@/Interfaces';
import { applyDeclarativeNodeOptionParameters } from '@/NodeHelpers';
import { RoutingNode } from '@/RoutingNode';
import * as utilsModule from '@/utils';
import { Workflow } from '@/Workflow';
import * as utilsModule from '@/utils';
import * as Helpers from './Helpers';
import { applyDeclarativeNodeOptionParameters } from '@/NodeHelpers';
import { mock } from 'jest-mock-extended';
const postReceiveFunction1 = async function (
this: IExecuteSingleFunctions,

View File

@@ -1,19 +1,20 @@
import { v5 as uuidv5, v3 as uuidv3, v4 as uuidv4, v1 as uuidv1 } from 'uuid';
import { mock } from 'jest-mock-extended';
import { v5 as uuidv5, v3 as uuidv3, v4 as uuidv4, v1 as uuidv1 } from 'uuid';
import { STICKY_NODE_TYPE } from '@/Constants';
import { ApplicationError } from '@/errors';
import { NodeConnectionType, type IWorkflowBase } from '@/Interfaces';
import * as nodeHelpers from '@/NodeHelpers';
import {
ANONYMIZATION_CHARACTER as CHAR,
generateNodesGraph,
getDomainBase,
getDomainPath,
} from '@/TelemetryHelpers';
import { nodeTypes } from './ExpressionExtensions/Helpers';
import * as nodeHelpers from '@/NodeHelpers';
import { NodeConnectionType, type IWorkflowBase } from '@/Interfaces';
import { STICKY_NODE_TYPE } from '@/Constants';
import { ApplicationError } from '@/errors';
import { randomInt } from '@/utils';
import { nodeTypes } from './ExpressionExtensions/Helpers';
describe('getDomainBase should return protocol plus domain', () => {
test('in valid URLs', () => {
for (const url of validUrls(numericId)) {

View File

@@ -1,4 +1,5 @@
import { DateTime } from 'luxon';
import { getValueDescription, validateFieldType } from '@/TypeValidation';
describe('Type Validation', () => {

View File

@@ -1,4 +1,5 @@
import { mock } from 'jest-mock-extended';
import { NodeConnectionType } from '@/Interfaces';
import type {
IBinaryKeyData,
@@ -18,8 +19,8 @@ import type {
IWorkflowExecuteAdditionalData,
NodeParameterValueType,
} from '@/Interfaces';
import { Workflow, type WorkflowParameters } from '@/Workflow';
import * as NodeHelpers from '@/NodeHelpers';
import { Workflow, type WorkflowParameters } from '@/Workflow';
process.env.TEST_VARIABLE_1 = 'valueEnvVariable1';

View File

@@ -1,3 +1,4 @@
import { ExpressionError } from '@/errors/expression.error';
import type {
IExecuteData,
INode,
@@ -8,7 +9,7 @@ import type {
} from '@/Interfaces';
import { Workflow } from '@/Workflow';
import { WorkflowDataProxy } from '@/WorkflowDataProxy';
import { ExpressionError } from '@/errors/expression.error';
import * as Helpers from './Helpers';
const loadFixture = (fixture: string) => {

View File

@@ -1,7 +1,8 @@
import { mock } from 'jest-mock-extended';
import type { INode } from '@/Interfaces';
import { NodeApiError } from '@/errors/node-api.error';
import { NodeOperationError } from '@/errors/node-operation.error';
import type { INode } from '@/Interfaces';
describe('NodeError', () => {
const node = mock<INode>();