From 4f820400831f2b320bc02de82755d5ae4e8e7987 Mon Sep 17 00:00:00 2001 From: Alex Grozav Date: Fri, 16 May 2025 16:46:09 +0300 Subject: [PATCH] refactor(editor): Migrate `agentRequest` store to `@n8n/stores` package (no-changelog) (#15462) --- packages/frontend/@n8n/stores/package.json | 2 ++ .../stores/src/useAgentRequestStore.test.ts} | 2 +- .../stores/src/useAgentRequestStore.ts} | 2 +- packages/frontend/editor-ui/package.json | 2 +- .../src/components/FromAiParametersModal.test.ts | 2 +- .../editor-ui/src/components/FromAiParametersModal.vue | 2 +- .../editor-ui/src/composables/useRunWorkflow.test.ts | 2 +- .../frontend/editor-ui/src/composables/useRunWorkflow.ts | 2 +- packages/frontend/editor-ui/src/views/NodeView.vue | 2 +- pnpm-lock.yaml | 8 +++++++- pnpm-workspace.yaml | 1 + 11 files changed, 18 insertions(+), 9 deletions(-) rename packages/frontend/{editor-ui/src/stores/agentRequest.store.test.ts => @n8n/stores/src/useAgentRequestStore.test.ts} (99%) rename packages/frontend/{editor-ui/src/stores/agentRequest.store.ts => @n8n/stores/src/useAgentRequestStore.ts} (98%) diff --git a/packages/frontend/@n8n/stores/package.json b/packages/frontend/@n8n/stores/package.json index 700ba8dc22..371cf4621a 100644 --- a/packages/frontend/@n8n/stores/package.json +++ b/packages/frontend/@n8n/stores/package.json @@ -45,6 +45,7 @@ "@vitejs/plugin-vue": "catalog:frontend", "@vue/tsconfig": "catalog:frontend", "@vueuse/core": "catalog:frontend", + "pinia": "catalog:frontend", "vue": "catalog:frontend", "tsup": "catalog:", "typescript": "catalog:frontend", @@ -54,6 +55,7 @@ }, "peerDependencies": { "@vueuse/core": "catalog:frontend", + "pinia": "catalog:frontend", "vue": "catalog:frontend" }, "license": "See LICENSE.md file in the root of the repository" diff --git a/packages/frontend/editor-ui/src/stores/agentRequest.store.test.ts b/packages/frontend/@n8n/stores/src/useAgentRequestStore.test.ts similarity index 99% rename from packages/frontend/editor-ui/src/stores/agentRequest.store.test.ts rename to packages/frontend/@n8n/stores/src/useAgentRequestStore.test.ts index f0d7f4b1f5..d47abefbf4 100644 --- a/packages/frontend/editor-ui/src/stores/agentRequest.store.test.ts +++ b/packages/frontend/@n8n/stores/src/useAgentRequestStore.test.ts @@ -1,5 +1,5 @@ import { setActivePinia, createPinia } from 'pinia'; -import { useAgentRequestStore } from './agentRequest.store'; +import { useAgentRequestStore } from './useAgentRequestStore'; import { beforeEach, describe, expect, it, vi } from 'vitest'; import { nextTick } from 'vue'; diff --git a/packages/frontend/editor-ui/src/stores/agentRequest.store.ts b/packages/frontend/@n8n/stores/src/useAgentRequestStore.ts similarity index 98% rename from packages/frontend/editor-ui/src/stores/agentRequest.store.ts rename to packages/frontend/@n8n/stores/src/useAgentRequestStore.ts index 344ce6dba5..f477c9cf5d 100644 --- a/packages/frontend/editor-ui/src/stores/agentRequest.store.ts +++ b/packages/frontend/@n8n/stores/src/useAgentRequestStore.ts @@ -1,4 +1,4 @@ -import { type INodeParameters, type NodeParameterValueType } from 'n8n-workflow'; +import type { INodeParameters, NodeParameterValueType } from 'n8n-workflow'; import { defineStore } from 'pinia'; import { ref, watch } from 'vue'; diff --git a/packages/frontend/editor-ui/package.json b/packages/frontend/editor-ui/package.json index 905409066e..70f1c54599 100644 --- a/packages/frontend/editor-ui/package.json +++ b/packages/frontend/editor-ui/package.json @@ -72,7 +72,7 @@ "lodash-es": "^4.17.21", "luxon": "catalog:", "n8n-workflow": "workspace:*", - "pinia": "^2.2.4", + "pinia": "catalog:frontend", "prettier": "^3.3.3", "qrcode.vue": "^3.3.4", "stream-browserify": "^3.0.0", diff --git a/packages/frontend/editor-ui/src/components/FromAiParametersModal.test.ts b/packages/frontend/editor-ui/src/components/FromAiParametersModal.test.ts index 7570ce970c..54083fc48e 100644 --- a/packages/frontend/editor-ui/src/components/FromAiParametersModal.test.ts +++ b/packages/frontend/editor-ui/src/components/FromAiParametersModal.test.ts @@ -5,7 +5,7 @@ import { FROM_AI_PARAMETERS_MODAL_KEY, AI_MCP_TOOL_NODE_TYPE } from '@/constants import { STORES } from '@n8n/stores'; import userEvent from '@testing-library/user-event'; import { useWorkflowsStore } from '@/stores/workflows.store'; -import { useAgentRequestStore } from '@/stores/agentRequest.store'; +import { useAgentRequestStore } from '@n8n/stores/useAgentRequestStore'; import { useRouter } from 'vue-router'; import { NodeConnectionTypes } from 'n8n-workflow'; import { useNodeTypesStore } from '@/stores/nodeTypes.store'; diff --git a/packages/frontend/editor-ui/src/components/FromAiParametersModal.vue b/packages/frontend/editor-ui/src/components/FromAiParametersModal.vue index d45e678d33..ae63647814 100644 --- a/packages/frontend/editor-ui/src/components/FromAiParametersModal.vue +++ b/packages/frontend/editor-ui/src/components/FromAiParametersModal.vue @@ -2,7 +2,7 @@ import { useI18n } from '@/composables/useI18n'; import { useRunWorkflow } from '@/composables/useRunWorkflow'; import { FROM_AI_PARAMETERS_MODAL_KEY, AI_MCP_TOOL_NODE_TYPE } from '@/constants'; -import { useAgentRequestStore } from '@/stores/agentRequest.store'; +import { useAgentRequestStore } from '@n8n/stores/useAgentRequestStore'; import { useWorkflowsStore } from '@/stores/workflows.store'; import { createEventBus } from '@n8n/utils/event-bus'; import { diff --git a/packages/frontend/editor-ui/src/composables/useRunWorkflow.test.ts b/packages/frontend/editor-ui/src/composables/useRunWorkflow.test.ts index 6fe1cf3fee..7a84449fc6 100644 --- a/packages/frontend/editor-ui/src/composables/useRunWorkflow.test.ts +++ b/packages/frontend/editor-ui/src/composables/useRunWorkflow.test.ts @@ -25,7 +25,7 @@ import { useSettingsStore } from '@/stores/settings.store'; import { usePushConnectionStore } from '@/stores/pushConnection.store'; import { createTestNode, createTestWorkflow } from '@/__tests__/mocks'; import { waitFor } from '@testing-library/vue'; -import { useAgentRequestStore } from '@/stores/agentRequest.store'; +import { useAgentRequestStore } from '@n8n/stores/useAgentRequestStore'; vi.mock('@/stores/workflows.store', () => { const storeState: Partial> & { diff --git a/packages/frontend/editor-ui/src/composables/useRunWorkflow.ts b/packages/frontend/editor-ui/src/composables/useRunWorkflow.ts index c99691f151..c5a1103c9d 100644 --- a/packages/frontend/editor-ui/src/composables/useRunWorkflow.ts +++ b/packages/frontend/editor-ui/src/composables/useRunWorkflow.ts @@ -43,7 +43,7 @@ import { useSettingsStore } from '@/stores/settings.store'; import { usePushConnectionStore } from '@/stores/pushConnection.store'; import { useNodeDirtiness } from '@/composables/useNodeDirtiness'; import { useCanvasOperations } from './useCanvasOperations'; -import { useAgentRequestStore } from '@/stores/agentRequest.store'; +import { useAgentRequestStore } from '@n8n/stores/useAgentRequestStore'; export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType }) { const nodeHelpers = useNodeHelpers(); diff --git a/packages/frontend/editor-ui/src/views/NodeView.vue b/packages/frontend/editor-ui/src/views/NodeView.vue index 19437d3601..ce2fcec161 100644 --- a/packages/frontend/editor-ui/src/views/NodeView.vue +++ b/packages/frontend/editor-ui/src/views/NodeView.vue @@ -120,7 +120,7 @@ import { useWorkflowSaving } from '@/composables/useWorkflowSaving'; import { useBuilderStore } from '@/stores/builder.store'; import { useFoldersStore } from '@/stores/folders.store'; import KeyboardShortcutTooltip from '@/components/KeyboardShortcutTooltip.vue'; -import { useAgentRequestStore } from '@/stores/agentRequest.store'; +import { useAgentRequestStore } from '@n8n/stores/useAgentRequestStore'; import { needsAgentInput } from '@/utils/nodes/nodeTransforms'; import { useLogsStore } from '@/stores/logs.store'; diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index b6caed87bd..e5bbc9a1a7 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -139,6 +139,9 @@ catalogs: highlight.js: specifier: ^11.8.0 version: 11.9.0 + pinia: + specifier: ^2.2.4 + version: 2.2.4 vite: specifier: ^6.3.5 version: 6.3.5 @@ -1884,6 +1887,9 @@ importers: '@vueuse/core': specifier: catalog:frontend version: 10.11.0(vue@3.5.13(typescript@5.8.2)) + pinia: + specifier: catalog:frontend + version: 2.2.4(typescript@5.8.2)(vue@3.5.13(typescript@5.8.2)) tsup: specifier: 'catalog:' version: 8.4.0(@microsoft/api-extractor@7.52.1(@types/node@18.16.16))(jiti@1.21.0)(postcss@8.5.3)(tsx@4.19.3)(typescript@5.8.2) @@ -2080,7 +2086,7 @@ importers: specifier: workspace:* version: link:../../workflow pinia: - specifier: ^2.2.4 + specifier: catalog:frontend version: 2.2.4(typescript@5.8.2)(vue@3.5.13(typescript@5.8.2)) prettier: specifier: ^3.3.3 diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 1f6a9c4171..13efe6cb0b 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -52,6 +52,7 @@ catalogs: '@vitest/coverage-v8': ^3.1.3 '@vitejs/plugin-vue': ^5.2.4 '@sentry/vue': ^8.33.1 + pinia: ^2.2.4 typescript: ^5.8.2 vite: ^6.3.5 vitest: ^3.1.3