admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove dead pubsub code (#11180)

Browse Source
This commit is contained in:
Iván Ovejero
2024-10-09 12:56:06 +02:00
committed by GitHub
parent d69842c87d
commit 518e320404
9 changed files with 13 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cli/src/scaling/__tests__/publisher.service.test.ts
View File

@@ -61,7 +61,7 @@ describe('Publisher', () => {
it('should publish worker response into `n8n.worker-response` pubsub channel', async () => {
const publisher = new Publisher(mock(), redisClientService);
const msg = mock<PubSub.WorkerResponse>({
command: 'reload-external-secrets-providers',
command: 'get-worker-status',
});
await publisher.publishWorkerResponse(msg);

21
packages/cli/src/scaling/__tests__/pubsub-handler.test.ts
View File

@@ -195,7 +195,6 @@ describe('PubSubHandler', () => {
'community-package-update': expect.any(Function),
'community-package-uninstall': expect.any(Function),
'get-worker-status': expect.any(Function),
'get-worker-id': expect.any(Function),
});
});
@@ -266,25 +265,5 @@ describe('PubSubHandler', () => {
expect(workerStatus.generateStatus).toHaveBeenCalled();
});
it('should get worker ID on `get-worker-id` event', () => {
new PubSubHandler(
eventService,
instanceSettings,
license,
eventbus,
externalSecretsManager,
communityPackagesService,
publisher,
workerStatus,
).init();
eventService.emit('get-worker-id');
expect(publisher.publishWorkerResponse).toHaveBeenCalledWith({
workerId: expect.any(String),
command: 'get-worker-id',
});
});
});
});

5
packages/cli/src/scaling/pubsub/pubsub-handler.ts
View File

@@ -43,11 +43,6 @@ export class PubSubHandler {
command: 'get-worker-status',
payload: this.workerStatus.generateStatus(),
}),
'get-worker-id': async () =>
await this.publisher.publishWorkerResponse({
workerId: config.getEnv('redis.queueModeId'),
command: 'get-worker-id',
}),
});
break;
case 'main':

14
packages/cli/src/scaling/pubsub/pubsub.types.ts
View File

@@ -86,18 +86,6 @@ export namespace PubSub {
_ToWorkerResponse<WorkerResponseKey>
>;
namespace WorkerResponses {
export type RestartEventBus = ToWorkerResponse<'restart-event-bus'>;
export type ReloadExternalSecretsProviders =
ToWorkerResponse<'reload-external-secrets-providers'>;
export type GetWorkerId = ToWorkerResponse<'get-worker-id'>;
export type GetWorkerStatus = ToWorkerResponse<'get-worker-status'>;
}
/** Response sent via the `n8n.worker-response` pubsub channel. */
export type WorkerResponse =
| WorkerResponses.RestartEventBus
| WorkerResponses.ReloadExternalSecretsProviders
| WorkerResponses.GetWorkerId
| WorkerResponses.GetWorkerStatus;
export type WorkerResponse = ToWorkerResponse<'get-worker-status'>;
}