admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(Google Sheets Node): Stop reporting to Sentry sheet not found error (no-changelog) (#7617)

Browse Source 
https://n8nio.sentry.io/issues/4264383378
This commit is contained in:
Iván Ovejero
2023-11-06 11:36:22 +01:00
committed by GitHub
parent b11c4de039
commit 52f655f3d2
5 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/nodes-base/nodes/Google/Sheet/v2/helpers/GoogleSheet.ts
View File

@@ -3,6 +3,7 @@ import type {
ILoadOptionsFunctions,
IDataObject,
IPollFunctions,
INode,
} from 'n8n-workflow';
import { NodeOperationError } from 'n8n-workflow';
import { utils as xlsxUtils } from 'xlsx';
@@ -117,7 +118,7 @@ export class GoogleSheet {
/**
* Returns the name of a sheet from a sheet id
*/
async spreadsheetGetSheetNameById(sheetId: string) {
async spreadsheetGetSheetNameById(node: INode, sheetId: string) {
const query = {
fields: 'sheets.properties',
};
@@ -133,9 +134,13 @@ export class GoogleSheet {
const foundItem = response.sheets.find(
(item: { properties: { sheetId: number } }) => item.properties.sheetId === +sheetId,
);
if (!foundItem?.properties?.title) {
throw new Error(`Sheet with id ${sheetId} not found`);
throw new NodeOperationError(node, `Sheet with ID ${sheetId} not found`, {
severity: 'warning',
});
}
return foundItem.properties.title;
}