admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-19 02:51:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): Fix new node credential creation via Resource Locator Component (#9896)

Browse Source
This commit is contained in:
Alex Grozav
2024-07-01 14:48:39 +03:00
committed by GitHub
parent 59c8bf1c44
commit 55cbc900a4
5 changed files with 84 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
packages/editor-ui/src/components/NodeCredentials.vue
View File

@@ -147,6 +147,7 @@ import {
isRequiredCredential,
} from '@/utils/nodeTypesUtils';
import { assert } from '@/utils/assert';
import { ndvEventBus } from '@/event-bus';
interface CredentialDropdownOption extends ICredentialsResponse {
typeDisplayName: string;
@@ -334,6 +335,11 @@ export default defineComponent({
}
});
});
ndvEventBus.on('credential.createNew', this.onCreateAndAssignNewCredential);
},
beforeUnmount() {
ndvEventBus.off('credential.createNew', this.onCreateAndAssignNewCredential);
},
methods: {
getAllRelatedCredentialTypes(credentialType: INodeCredentialDescription): string[] {
@@ -416,25 +422,45 @@ export default defineComponent({
this.$emit('credentialSelected', updateInformation);
},
onCredentialSelected(
createNewCredential(
credentialType: string,
credentialId: string | null | undefined,
requiredCredentials = false,
listenForAuthChange: boolean = false,
showAuthOptions = false,
) {
if (credentialId === this.NEW_CREDENTIALS_TEXT) {
if (listenForAuthChange) {
// If new credential dialog is open, start listening for auth type change which should happen in the modal
// this will be handled in this component's watcher which will set subscribed credential accordingly
this.listeningForAuthChange = true;
this.subscribedToCredentialType = credentialType;
}
if (!credentialId || credentialId === this.NEW_CREDENTIALS_TEXT) {
this.uiStore.openNewCredential(credentialType, requiredCredentials);
this.$telemetry.track('User opened Credential modal', {
credential_type: credentialType,
source: 'node',
new_credential: true,
workflow_id: this.workflowsStore.workflowId,
});
this.uiStore.openNewCredential(credentialType, showAuthOptions);
this.$telemetry.track('User opened Credential modal', {
credential_type: credentialType,
source: 'node',
new_credential: true,
workflow_id: this.workflowsStore.workflowId,
});
},
onCreateAndAssignNewCredential({
type,
showAuthOptions,
}: {
type: string;
showAuthOptions: boolean;
}) {
this.createNewCredential(type, true, showAuthOptions);
},
onCredentialSelected(
credentialType: string,
credentialId: string | null | undefined,
showAuthOptions = false,
) {
const newCredentialOptionSelected = credentialId === this.NEW_CREDENTIALS_TEXT;
if (!credentialId || newCredentialOptionSelected) {
this.createNewCredential(credentialType, newCredentialOptionSelected, showAuthOptions);
return;
}