🎨 Set up linting and formatting (#2120)

* ⬆️ Upgrade TS to 4.3.5

* 👕 Add ESLint configs

* 🎨 Add Prettier config

* 📦 Add deps and commands

* ⚡ Adjust global .editorconfig to new ruleset

* 🔥 Remove unneeded local .editorconfig

* 📦 Update deps in editor-ui

* 🔨 Limit Prettier to only TS files

* ⚡ Add recommended VSCode extensions

* 👕 Fix build

* 🔥 Remove Vue setting from global config

* ⚡ Disable prefer-default-export per feedback

* ✏️ Add forgotten divider

* 👕 Disable no-plusplus

* 👕 Disable class-methods-use-this

* ✏️ Alphabetize overrides

* 👕 Add one-var consecutive override

* ⏪ Revert one-var consecutive override

This reverts commit b9252cf935659ba6d76727ad484a1d3c00008fcc.

* 🎨 👕 Lint and format workflow package (#2121)

* 🎨 Format /workflow package

* 👕 Lint /workflow package

* 🎨 Re-format /workflow package

* 👕 Re-lint /workflow package

* ✏️ Fix typo

* ⚡ Consolidate if-checks

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 🎨 👕 Lint and format node-dev package (#2122)

* 🎨 Format /node-dev package

* ⚡ Exclude templates from ESLint config

This keeps the templates consistent with the codebase while preventing lint exceptions from being made part of the templates.

* 👕 Lint /node-dev package

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🎨 👕 Lint and format core package (#2123)

* 🎨 Format /core package

* 👕 Lint /core package

* 🎨 Re-format /core package

* 👕 Re-lint /core package

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 🎨 👕 Lint and format cli package (#2124)

* 🎨 Format /cli package

* 👕 Exclude migrations from linting

* 👕 Lint /cli package

* 🎨 Re-format /cli package

* 👕 Re-lint /cli package

* 👕 Fix build

* 🔥 Remove prefer-default-export exceptions

* ⚡ Update exceptions in ActiveExecutions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 👕 fix lint issues

* 🔧 use package specific linter, remove tslint command

* 🔨 resolve build issue, sync dependencies

* 🔧 change lint command

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

packages/cli/src/Queue.ts

@@ -1,14 +1,15 @@
 import * as Bull from 'bull';
 import * as config from '../config';
+// eslint-disable-next-line import/no-cycle
 import { IBullJobData } from './Interfaces';
 
 export class Queue {
 	private jobQueue: Bull.Queue;
-	
+
 	constructor() {
 		const prefix = config.get('queue.bull.prefix') as string;
 		const redisOptions = config.get('queue.bull.redis') as object;
-		// Disabling ready check is necessary as it allows worker to 
+		// Disabling ready check is necessary as it allows worker to
 		// quickly reconnect to Redis if Redis crashes or is unreachable
 		// for some time. With it enabled, worker might take minutes to realize
 		// redis is back up and resume working.
@@ -16,25 +17,25 @@ export class Queue {
 		// @ts-ignore
 		this.jobQueue = new Bull('jobs', { prefix, redis: redisOptions, enableReadyCheck: false });
 	}
-	
+
 	async add(jobData: IBullJobData, jobOptions: object): Promise<Bull.Job> {
-		return await this.jobQueue.add(jobData,jobOptions);
+		return this.jobQueue.add(jobData, jobOptions);
 	}
-	
+
 	async getJob(jobId: Bull.JobId): Promise<Bull.Job | null> {
-		return await this.jobQueue.getJob(jobId);
+		return this.jobQueue.getJob(jobId);
 	}
-	
+
 	async getJobs(jobTypes: Bull.JobStatus[]): Promise<Bull.Job[]> {
-		return await this.jobQueue.getJobs(jobTypes);
+		return this.jobQueue.getJobs(jobTypes);
 	}
-	
+
 	getBullObjectInstance(): Bull.Queue {
 		return this.jobQueue;
 	}
 
 	/**
-	 * 
+	 *
 	 * @param job A Bull.Job instance
 	 * @returns boolean true if we were able to securely stop the job
 	 */
@@ -43,15 +44,15 @@ export class Queue {
 			// Job is already running so tell it to stop
 			await job.progress(-1);
 			return true;
-		} else {
-			// Job did not get started yet so remove from queue
-			try {
-				await job.remove();
-				return true;
-			} catch (e) {
-				await job.progress(-1);
-			}
 		}
+		// Job did not get started yet so remove from queue
+		try {
+			await job.remove();
+			return true;
+		} catch (e) {
+			await job.progress(-1);
+		}
+
 		return false;
 	}
 }
@@ -62,6 +63,6 @@ export function getInstance(): Queue {
 	if (activeQueueInstance === undefined) {
 		activeQueueInstance = new Queue();
 	}
-	
+
 	return activeQueueInstance;
 }